Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/21426 )
Change subject: IMPALA-12216: Print timestamp for impala-shell errors ...................................................................... Patch Set 17: Code-Review+1 (4 comments) http://gerrit.cloudera.org:8080/#/c/21426/17//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21426/17//COMMIT_MSG@11 PS17, Line 11: nit: can we add an example for the new output? http://gerrit.cloudera.org:8080/#/c/21426/17/tests/custom_cluster/test_hs2_fault_injection.py File tests/custom_cluster/test_hs2_fault_injection.py: http://gerrit.cloudera.org:8080/#/c/21426/17/tests/custom_cluster/test_hs2_fault_injection.py@31 PS17, Line 31: TS_LEN = 20 nit: can we add an example in the comment about how the timestamp looks like? Just want to make it clear why the length is 20. http://gerrit.cloudera.org:8080/#/c/21426/17/tests/shell/test_shell_commandline.py File tests/shell/test_shell_commandline.py: http://gerrit.cloudera.org:8080/#/c/21426/17/tests/shell/test_shell_commandline.py@56 PS17, Line 56: TS_LEN = 20 nit: please add the same comment http://gerrit.cloudera.org:8080/#/c/21426/17/tests/shell/test_shell_interactive.py File tests/shell/test_shell_interactive.py: http://gerrit.cloudera.org:8080/#/c/21426/17/tests/shell/test_shell_interactive.py@343 PS17, Line 343: assert "Cancelled" not in result.stderr nit: don't need to reorder this -- To view, visit http://gerrit.cloudera.org:8080/21426 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I4abbd02aa9f61210b0333495bf191e72c22a5944 Gerrit-Change-Number: 21426 Gerrit-PatchSet: 17 Gerrit-Owner: Saurabh Katiyal <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Saurabh Katiyal <[email protected]> Gerrit-Comment-Date: Thu, 22 Aug 2024 07:07:30 +0000 Gerrit-HasComments: Yes
