Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21596 )
Change subject: IMPALA-12576: Display warning on the query timeline page for the experimental profile ...................................................................... Patch Set 2: (3 comments) http://gerrit.cloudera.org:8080/#/c/21596/2/www/scripts/query_timeline/fragment_diagram.js File www/scripts/query_timeline/fragment_diagram.js: http://gerrit.cloudera.org:8080/#/c/21596/2/www/scripts/query_timeline/fragment_diagram.js@351 PS2, Line 351: execution_profile.child_profiles[1].profile_name.startsWith("Averaged") Do we print TRuntimeProfileTree.profile_version in json profile format today? We probably should start doing that for easy distinction. Feel free to file a follow up JIRA. http://gerrit.cloudera.org:8080/#/c/21596/2/www/scripts/query_timeline/fragment_diagram.js@352 PS2, Line 352: Warning: Instance level details are : unavailable, when <b><i>gen_experimental_profile</i></b> is set to : <b><i>true</i></b>. I'd like to suggest rewording this to: `Warning: Instance level details are unavailable. Query profile might be in Version 2 format (<b><i>gen_experimental_profile</i></b> flag is set to <b><i>true</i></b>).` http://gerrit.cloudera.org:8080/#/c/21596/2/www/scripts/query_timeline/fragment_metrics_diagram.js File www/scripts/query_timeline/fragment_metrics_diagram.js: http://gerrit.cloudera.org:8080/#/c/21596/2/www/scripts/query_timeline/fragment_metrics_diagram.js@202 PS2, Line 202: "Warning: Not enough samples for fragment metrics plot." Unnecessary change? -- To view, visit http://gerrit.cloudera.org:8080/21596 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I6ad62be3572b7a126ce10dc4a11fcc9b8a58013d Gerrit-Change-Number: 21596 Gerrit-PatchSet: 2 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Reviewer: Zihao Ye <[email protected]> Gerrit-Comment-Date: Thu, 22 Aug 2024 16:05:19 +0000 Gerrit-HasComments: Yes
