Michael Smith has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21142 )

Change subject: IMPALA-12737: Query columns in workload management tables.
......................................................................


Patch Set 35:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/21142/32/be/src/service/workload-management-init.cc
File be/src/service/workload-management-init.cc:

http://gerrit.cloudera.org:8080/#/c/21142/32/be/src/service/workload-management-init.cc@328
PS32, Line 328:     // Create the live query table on the target schema version.
> When running alter table add column if not exists on sys.impala_query_live,
That sounds like a bug we should investigate, it shouldn't lead to an 
IllegalStateException.


http://gerrit.cloudera.org:8080/#/c/21142/35/tests/common/impala_cluster.py
File tests/common/impala_cluster.py:

http://gerrit.cloudera.org:8080/#/c/21142/35/tests/common/impala_cluster.py@581
PS35, Line 581:   def is_coordinator(self):
Maybe update line 229 to use this helper?



--
To view, visit http://gerrit.cloudera.org:8080/21142
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I78f3670b067c0c192ee8a212fba95466fbcb51d7
Gerrit-Change-Number: 21142
Gerrit-PatchSet: 35
Gerrit-Owner: Michael Smith <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Jason Fehr <[email protected]>
Gerrit-Reviewer: Michael Smith <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Comment-Date: Thu, 22 Aug 2024 22:57:31 +0000
Gerrit-HasComments: Yes

Reply via email to