Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/10335 )
Change subject: test-with-docker: work with git worktree ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/10335/1/docker/test-with-docker.py File docker/test-with-docker.py: http://gerrit.cloudera.org:8080/#/c/10335/1/docker/test-with-docker.py@417 PS1, Line 417: self.git_common_dir = os.path.realpath( : _check_output(["git", "rev-parse", "--git-common-dir"]).strip()) > When I run this on one of my normal checkouts, it does this: Ah, good find. It first showed up in the documentation at https://git-scm.com/docs/git-rev-parse/2.5.1 or so, and first showed up in git in 2.5.0, based on finding the commit and looking for tags that contain it. I added code here that handles both cases. I can imagine someone running RH7/CentOS 7 with an old git but with Docker. -- To view, visit http://gerrit.cloudera.org:8080/10335 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I9186e0b6f068aacc25f8d691508165c04329fa8b Gerrit-Change-Number: 10335 Gerrit-PatchSet: 1 Gerrit-Owner: Philip Zeyliger <phi...@cloudera.com> Gerrit-Reviewer: Joe McDonnell <joemcdonn...@cloudera.com> Gerrit-Reviewer: Kim Jin Chul <jinc...@gmail.com> Gerrit-Reviewer: Philip Zeyliger <phi...@cloudera.com> Gerrit-Comment-Date: Mon, 14 May 2018 19:12:17 +0000 Gerrit-HasComments: Yes
