Laszlo Gaal has posted comments on this change. ( http://gerrit.cloudera.org:8080/21656 )
Change subject: IMPALA-11729: Speed up start-impala-cluster.py ...................................................................... Patch Set 5: Code-Review+1 (2 comments) LGTM, just a typo. http://gerrit.cloudera.org:8080/#/c/21656/5/tests/common/impala_cluster.py File tests/common/impala_cluster.py: http://gerrit.cloudera.org:8080/#/c/21656/5/tests/common/impala_cluster.py@622 PS5, Line 622: coordinor nit: typo http://gerrit.cloudera.org:8080/#/c/21656/5/tests/common/impala_cluster.py@625 PS5, Line 625: TODO: shouldn't this also wait for hs2-http? I think it should (especially if regular core-mode tests use that port as well), but I'm OK with that being added in a follow-up patch. -- To view, visit http://gerrit.cloudera.org:8080/21656 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ic4dd8c2bc7056443373ceb256a03ce562fea38a0 Gerrit-Change-Number: 21656 Gerrit-PatchSet: 5 Gerrit-Owner: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Laszlo Gaal <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Mon, 26 Aug 2024 13:47:51 +0000 Gerrit-HasComments: Yes
