Dan Hecht has posted comments on this change. ( http://gerrit.cloudera.org:8080/10391 )
Change subject: Add a missing PrintId() ...................................................................... Patch Set 2: > Do we have a way to catch these automatically? > > I started looking at clang-query but I gave up after 5 minutes... Yeah, I had also looked to see if we had something we could add a rule to but also gave up. If we have something and someone can point me in the right direction, I'm happy to look. -- To view, visit http://gerrit.cloudera.org:8080/10391 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I701115fb7bc88cd034ddb7f0b99cf067ef2a7078 Gerrit-Change-Number: 10391 Gerrit-PatchSet: 2 Gerrit-Owner: Dan Hecht <[email protected]> Gerrit-Reviewer: Dan Hecht <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Philip Zeyliger <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Mon, 14 May 2018 20:47:04 +0000 Gerrit-HasComments: No
