Kurt Deschler has posted comments on this change. ( http://gerrit.cloudera.org:8080/21593 )
Change subject: IMPALA-13233: Improve display of instance-level skew in query timeline ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/21593/3/www/scripts/query_timeline/fragment_diagram.js File www/scripts/query_timeline/fragment_diagram.js: http://gerrit.cloudera.org:8080/#/c/21593/3/www/scripts/query_timeline/fragment_diagram.js@524 PS3, Line 524: var name_flds = pp.profile_name.split(/[()]/); : var node_type = name_flds[0].trim(); : var node_id = name_flds.length > 1 ? name_flds[1].split(/[=]/)[1] : 0; > Same here, I am not sure, why it was kept that way, need to confirm. Are their any implications of using string vs integer in this code? http://gerrit.cloudera.org:8080/#/c/21593/3/www/scripts/query_timeline/fragment_diagram.js@548 PS3, Line 548: node_metadata.join_build_id > I will confirm with @kdeschle, I also could not find it. join_build_id should be an mt_dop case that uses join build but I don't remember the details of the json content. -- To view, visit http://gerrit.cloudera.org:8080/21593 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ied8a5966e9e4111bf7aa25aee11d23881daad7d2 Gerrit-Change-Number: 21593 Gerrit-PatchSet: 3 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Tue, 27 Aug 2024 12:07:30 +0000 Gerrit-HasComments: Yes
