Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21728 )
Change subject: WIP IMPALA-13288: OAuth AuthN Support for Impala ...................................................................... Patch Set 1: (33 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python2 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with virtualenv installed. http://gerrit.cloudera.org:8080/#/c/21728/1/be/src/transport/THttpServer.h File be/src/transport/THttpServer.h: http://gerrit.cloudera.org:8080/#/c/21728/1/be/src/transport/THttpServer.h@147 PS1, Line 147: std::function<bool(const std::string&)> oauth_token_auth_fn = [&](const std::string&) { line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/21728/1/be/src/transport/THttpServer.h@195 PS1, Line 195: // client on requests that do not contain a valid 'Authorization' of SAML SSO or JWT or Oauth line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/21728/1/be/src/util/oauth-util-internal.h File be/src/util/oauth-util-internal.h: http://gerrit.cloudera.org:8080/#/c/21728/1/be/src/util/oauth-util-internal.h@245 PS1, Line 245: /// It's a snapshot of the current oauthS. The oauthSMgr maintains a consistent copy of this line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21728/1/be/src/util/oauth-util-internal.h@246 PS1, Line 246: /// and updates it atomically when the public keys in oauthS are changed. Clients can obtain line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21728/1/be/src/util/oauth-util-internal.h@255 PS1, Line 255: typedef std::unordered_map<std::string, std::unique_ptr<OAUTHPublicKey>> OAUTHPublicKeyMap; line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/21728/1/be/src/util/oauth-util-internal.h@378 PS1, Line 378: /// The snapshot of the current oauthS. When the checksum of downloaded oauthS json object line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21728/1/be/src/util/oauth-util-test.cc File be/src/util/oauth-util-test.cc: http://gerrit.cloudera.org:8080/#/c/21728/1/be/src/util/oauth-util-test.cc@405 PS1, Line 405: rsa_pub_key_oauth_n, rsa_pub_key_oauth_e, kid_2, "RS256", rsa_invalid_pub_key_oauth_n, line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21728/1/be/src/util/oauth-util-test.cc@466 PS1, Line 466: Substitute(oauths_rsa_file_format, "", "RS256", rsa_pub_key_oauth_n, rsa_pub_key_oauth_e, line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/21728/1/be/src/util/oauth-util-test.cc@478 PS1, Line 478: Substitute(oauths_rsa_file_format, kid_1, "RS256", "", "", kid_2, "RS256", "", ""))); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/21728/1/be/src/util/oauth-util-test.cc@514 PS1, Line 514: // Verify the Oauth token with our wrapper class which use public key retrieved from oauthS, line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/21728/1/be/src/util/oauth-util-test.cc@554 PS1, Line 554: // Verify the Oauth token with our wrapper class which use public key retrieved from oauthS, line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/21728/1/be/src/util/oauth-util-test.cc@594 PS1, Line 594: // Verify the Oauth token with our wrapper class which use public key retrieved from oauthS, line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/21728/1/be/src/util/oauth-util-test.cc@610 PS1, Line 610: rsa_pub_key_oauth_n, rsa_pub_key_oauth_e, kid_2, "RS256", rsa_invalid_pub_key_oauth_n, line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21728/1/be/src/util/oauth-util-test.cc@644 PS1, Line 644: .allow_algorithm(Oauth::algorithm::rs256(rsa_pub_key_pem, "", "", "")) line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21728/1/be/src/util/oauth-util-test.cc@648 PS1, Line 648: // Verify the Oauth token with our wrapper class which use public key retrieved from oauthS, line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/21728/1/be/src/util/oauth-util-test.cc@664 PS1, Line 664: rsa_pub_key_oauth_n, rsa_pub_key_oauth_e, kid_2, "RS384", rsa_invalid_pub_key_oauth_n, line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21728/1/be/src/util/oauth-util-test.cc@686 PS1, Line 686: // Verify the Oauth token with our wrapper class which use public key retrieved from oauthS, line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/21728/1/be/src/util/oauth-util-test.cc@724 PS1, Line 724: // Verify the Oauth token with our wrapper class which use public key retrieved from oauthS, line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/21728/1/be/src/util/oauth-util-test.cc@760 PS1, Line 760: .sign(Oauth::algorithm::ps256(rsa1024_pub_key_pem, rsa1024_priv_key_pem, "", "")); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21728/1/be/src/util/oauth-util-test.cc@762 PS1, Line 762: // Verify the Oauth token with our wrapper class which use public key retrieved from oauthS, line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/21728/1/be/src/util/oauth-util-test.cc@798 PS1, Line 798: .sign(Oauth::algorithm::ps384(rsa2048_pub_key_pem, rsa2048_priv_key_pem, "", "")); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21728/1/be/src/util/oauth-util-test.cc@800 PS1, Line 800: // Verify the Oauth token with our wrapper class which use public key retrieved from oauthS, line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/21728/1/be/src/util/oauth-util-test.cc@836 PS1, Line 836: .sign(Oauth::algorithm::ps512(rsa4096_pub_key_pem, rsa4096_priv_key_pem, "", "")); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21728/1/be/src/util/oauth-util-test.cc@838 PS1, Line 838: // Verify the Oauth token with our wrapper class which use public key retrieved from oauthS, line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/21728/1/be/src/util/oauth-util-test.cc@883 PS1, Line 883: // Verify the Oauth token with our wrapper class which use public key retrieved from oauthS, line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/21728/1/be/src/util/oauth-util-test.cc@920 PS1, Line 920: // Verify the Oauth token with our wrapper class which use public key retrieved from oauthS, line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/21728/1/be/src/util/oauth-util-test.cc@957 PS1, Line 957: // Verify the Oauth token with our wrapper class which use public key retrieved from oauthS, line too long (94 > 90) http://gerrit.cloudera.org:8080/#/c/21728/1/be/src/util/oauth-util-test.cc@993 PS1, Line 993: rsa_pub_key_oauth_n, rsa_pub_key_oauth_e, kid_2, "RS256", rsa_invalid_pub_key_oauth_n, line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21728/1/be/src/util/oauth-util-test.cc@1022 PS1, Line 1022: rsa_pub_key_oauth_n, rsa_pub_key_oauth_e, kid_2, "RS256", rsa_invalid_pub_key_oauth_n, line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21728/1/be/src/util/oauth-util-test.cc@1050 PS1, Line 1050: rsa_pub_key_oauth_n, rsa_pub_key_oauth_e, kid_2, "RS256", rsa_invalid_pub_key_oauth_n, line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21728/1/be/src/util/oauth-util-test.cc@1071 PS1, Line 1071: rsa_pub_key_oauth_n, rsa_pub_key_oauth_e, kid_2, "RS256", rsa_invalid_pub_key_oauth_n, line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21728/1/be/src/util/oauth-util-test.cc@1091 PS1, Line 1091: rsa_pub_key_oauth_n, rsa_pub_key_oauth_e, kid_2, "RS256", rsa_invalid_pub_key_oauth_n, line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21728/1/be/src/util/oauth-util-test.cc@1113 PS1, Line 1113: rsa_pub_key_oauth_n, rsa_pub_key_oauth_e, kid_2, "RS256", rsa_invalid_pub_key_oauth_n, line too long (92 > 90) -- To view, visit http://gerrit.cloudera.org:8080/21728 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I65dc8db917476b0f0d29b659b9fa51ebaf45b7a6 Gerrit-Change-Number: 21728 Gerrit-PatchSet: 1 Gerrit-Owner: gaurav singh <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Comment-Date: Tue, 27 Aug 2024 17:52:25 +0000 Gerrit-HasComments: Yes
