Anonymous Coward (801) has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21629 )

Change subject: IMPALA-13030: [DOCS] Documentation of AI built-in function 
(ai_generate_text)
......................................................................


Patch Set 2:

(3 comments)

I've left a couple of suggestions.

http://gerrit.cloudera.org:8080/#/c/21629/2/docs/topics/impala_ai_functions.xml
File docs/topics/impala_ai_functions.xml:

http://gerrit.cloudera.org:8080/#/c/21629/2/docs/topics/impala_ai_functions.xml@120
PS2, Line 120:           JCEKS keystore file.</li>
Probably worth mentioning that the config for this is 
hadoop.security.credential.provider.path in core-site configs for executor and 
coordinator


http://gerrit.cloudera.org:8080/#/c/21629/2/docs/topics/impala_ai_functions.xml@151
PS2, Line 151:         prompt. Once you build your custom UDF with the prompt, 
you can pass that prompt into the
Maybe change this to "Within your custom UDF, you can pass your desired prompt 
into the..." just to clarify that this all happens inside the UDF definition.


http://gerrit.cloudera.org:8080/#/c/21629/2/docs/topics/impala_ai_functions.xml@173
PS2, Line 173:       <p>Now you can define these prompt building UDF and build 
them in Impala. Once you have them
You might have meant UDF -> UDFs



--
To view, visit http://gerrit.cloudera.org:8080/21629
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae921f6554c7010f9568ee4a42b4abcb3534d4a6
Gerrit-Change-Number: 21629
Gerrit-PatchSet: 2
Gerrit-Owner: Sanjana Malhotra <[email protected]>
Gerrit-Reviewer: Abhishek Rawat <[email protected]>
Gerrit-Reviewer: Anonymous Coward (801)
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Yida Wu <[email protected]>
Gerrit-Comment-Date: Wed, 28 Aug 2024 22:59:53 +0000
Gerrit-HasComments: Yes

Reply via email to