Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21729 )
Change subject: IMPALA-13185: Include runtime filter source in key ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/21729/2/fe/src/main/java/org/apache/impala/planner/PlanNode.java File fe/src/main/java/org/apache/impala/planner/PlanNode.java: http://gerrit.cloudera.org:8080/#/c/21729/2/fe/src/main/java/org/apache/impala/planner/PlanNode.java@1353 PS2, Line 1353: PlanNode build = filter.getSrc().getBuildNode(); > I think finding the source this way is right, and I think the Calcite plann We already incorporate the Thrift representation of RuntimeFilter at https://gerrit.cloudera.org/c/21729/2/fe/src/main/java/org/apache/impala/planner/PlanNode.java#1353. I'll have to look at whether those details make it into the srcExpr/targetExpr. -- To view, visit http://gerrit.cloudera.org:8080/21729 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0077964be5acdb588d76251a6a39e57a0f42bb5a Gerrit-Change-Number: 21729 Gerrit-PatchSet: 2 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 28 Aug 2024 23:53:20 +0000 Gerrit-HasComments: Yes
