Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/21142 )
Change subject: IMPALA-12737: Query columns in workload management tables. ...................................................................... Patch Set 40: (3 comments) http://gerrit.cloudera.org:8080/#/c/21142/41/be/src/service/impala-server.h File be/src/service/impala-server.h: http://gerrit.cloudera.org:8080/#/c/21142/41/be/src/service/impala-server.h@1661 PS41, Line 1661: /// Note that these hold a shared pointer to 'this', and so need to be reset() > What maintains the lifetime of the InternalServer? I guess it's always a re Good point. It's not needed at all since ImpalaServer implements the InternalServer interface. I removed the internal_server_ variable. http://gerrit.cloudera.org:8080/#/c/21142/40/be/src/service/workload-management-init.cc File be/src/service/workload-management-init.cc: http://gerrit.cloudera.org:8080/#/c/21142/40/be/src/service/workload-management-init.cc@354 PS40, Line 354: // errors when running the alter table statements. > What happens when it does fail? Do you have to restart the coordinator? Is If it fails, the coordinator exits with an error via the ABORT_IF_ERROR function. An external process will need to restart the coordinator. The potential for failure only exists when upgrading from one version of workload management to another. I will test moving the jitter to the upgrade code path. http://gerrit.cloudera.org:8080/#/c/21142/41/be/src/service/workload-management.cc File be/src/service/workload-management.cc: http://gerrit.cloudera.org:8080/#/c/21142/41/be/src/service/workload-management.cc@65 PS41, Line 65: /// > What was the argument for moving these out of ImpalaServer and making them These variables are only used in this file, thus no need to make them available to in the ImpalaServer private scope. -- To view, visit http://gerrit.cloudera.org:8080/21142 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I78f3670b067c0c192ee8a212fba95466fbcb51d7 Gerrit-Change-Number: 21142 Gerrit-PatchSet: 40 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Thu, 29 Aug 2024 19:05:27 +0000 Gerrit-HasComments: Yes
