Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21698 )
Change subject: IMPALA-13186: Tag query option scope for tuple cache ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/21698/1/be/src/service/query-options.h File be/src/service/query-options.h: http://gerrit.cloudera.org:8080/#/c/21698/1/be/src/service/query-options.h@44 PS1, Line 44: // Scope descriptor for each query option to help with evaluating how different aspects of : // query execution are affected. Defined as a bitmask for options that affect multiple. : enum class QueryOptionScope : uint8_t { : None = 0, // Not part of any known scope : Performance = 1 << 0, // Solely impacts performance without changing plan or results : Plan = 1 << 1, // Can result in a different query plan : Results = 1 << 2, // Can produce different results in fragments of a query plan : All = 0xFF // Can affect any scope (mainly used for DEBUG_ACTION) : }; > My first thought is that this is somewhat abstract. I'm concerned a develop So maybe invert Results to ResultsUnaffected? We could also skip this whole idea and just have a list of query options that are safe to cache. Some are safe to cache but also change the plan, so they'd automatically have a different plan structure. It probably doesn't matter much whether they're directly included or not. -- To view, visit http://gerrit.cloudera.org:8080/21698 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1f4802ad9548749cd43df8848b6f46dca3739ae7 Gerrit-Change-Number: 21698 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Thu, 29 Aug 2024 22:41:07 +0000 Gerrit-HasComments: Yes
