Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21738 )

Change subject: Use cgroups for single_node_perf_run.py
......................................................................


Patch Set 1:

(9 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python2 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with virtualenv installed.

http://gerrit.cloudera.org:8080/#/c/21738/1/bin/single_node_perf_run.py
File bin/single_node_perf_run.py:

http://gerrit.cloudera.org:8080/#/c/21738/1/bin/single_node_perf_run.py@88
PS1, Line 88: import time
flake8: F401 'time' imported but unused


http://gerrit.cloudera.org:8080/#/c/21738/1/bin/single_node_perf_run.py@152
PS1, Line 152: _
flake8: E501 line too long (101 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/21738/1/bin/single_node_perf_run.py@156
PS1, Line 156: +
flake8: E226 missing whitespace around arithmetic operator


http://gerrit.cloudera.org:8080/#/c/21738/1/bin/single_node_perf_run.py@311
PS1, Line 311: c
flake8: E501 line too long (98 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/21738/1/bin/single_node_perf_run.py@327
PS1, Line 327: q
flake8: E501 line too long (104 > 90 characters)


http://gerrit.cloudera.org:8080/#/c/21738/1/bin/single_node_perf_run.py@332
PS1, Line 332: +
flake8: E226 missing whitespace around arithmetic operator


http://gerrit.cloudera.org:8080/#/c/21738/1/bin/single_node_perf_run.py@342
PS1, Line 342: *
flake8: E226 missing whitespace around arithmetic operator


http://gerrit.cloudera.org:8080/#/c/21738/1/bin/single_node_perf_run.py@353
PS1, Line 353: +
flake8: E226 missing whitespace around arithmetic operator


http://gerrit.cloudera.org:8080/#/c/21738/1/bin/single_node_perf_run.py@439
PS1, Line 439: a
flake8: E501 line too long (99 > 90 characters)



--
To view, visit http://gerrit.cloudera.org:8080/21738
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic9aa5618e9a92ad117782d082aef6870fba9f359
Gerrit-Change-Number: 21738
Gerrit-PatchSet: 1
Gerrit-Owner: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Tue, 03 Sep 2024 21:20:43 +0000
Gerrit-HasComments: Yes

Reply via email to