Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21743 )
Change subject: IMPALA-13349: Fix remaining tests with unexercised exec_option ...................................................................... Patch Set 2: (4 comments) http://gerrit.cloudera.org:8080/#/c/21743/1/tests/query_test/test_insert.py File tests/query_test/test_insert.py: http://gerrit.cloudera.org:8080/#/c/21743/1/tests/query_test/test_insert.py@47 PS1, Line 47: shoul > nit: delete redundant word 'class' Done http://gerrit.cloudera.org:8080/#/c/21743/1/tests/query_test/test_insert.py@54 PS1, Line 54: def add_test_dimensions(cls): > Isn't setup_class() inherited from the parent class, do we need to override Done http://gerrit.cloudera.org:8080/#/c/21743/1/tests/query_test/test_mt_dop.py File tests/query_test/test_mt_dop.py: http://gerrit.cloudera.org:8080/#/c/21743/1/tests/query_test/test_mt_dop.py@131 PS1, Line 131: TestMtDopNonZeroParquet > Maybe "TestNonZeroMtDopParquet" would be better, because NonZero refers to Done http://gerrit.cloudera.org:8080/#/c/21743/1/tests/query_test/test_sort.py File tests/query_test/test_sort.py: http://gerrit.cloudera.org:8080/#/c/21743/1/tests/query_test/test_sort.py@347 PS1, Line 347: These tes > Nit: "These tests". Done -- To view, visit http://gerrit.cloudera.org:8080/21743 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I33bb4b6c4ff50b55a082460dd9944d2aa3511e11 Gerrit-Change-Number: 21743 Gerrit-PatchSet: 2 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Wed, 04 Sep 2024 16:14:47 +0000 Gerrit-HasComments: Yes
