Jason Fehr has posted comments on this change. ( http://gerrit.cloudera.org:8080/21750 )
Change subject: IMPALA-13350: Fix Workload Management flush_on_interval Test ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/21750/1/tests/custom_cluster/test_query_log.py File tests/custom_cluster/test_query_log.py: http://gerrit.cloudera.org:8080/#/c/21750/1/tests/custom_cluster/test_query_log.py@688 PS1, Line 688: 20 > nit: I think double of query_log_write_interval_s for timeout value should I considered allowing for double the value of query_log_write_interval_s (which would be 30 seconds instead of 20) and ended up deciding that the extra time did not add any value considering the query execution will have already resulted in 10 seconds passing (10 queries with each one sleeping 1 second). -- To view, visit http://gerrit.cloudera.org:8080/21750 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2fb1034ca63e170d5e57a6ece9b47da5dafebff4 Gerrit-Change-Number: 21750 Gerrit-PatchSet: 1 Gerrit-Owner: Jason Fehr <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Wed, 04 Sep 2024 16:30:55 +0000 Gerrit-HasComments: Yes
