Mihaly Szjatinya has posted comments on this change. ( http://gerrit.cloudera.org:8080/21735 )
Change subject: IMPALA-7086: Cache timezone in *_utc_timestamp() ...................................................................... Patch Set 7: (3 comments) > Patch Set 7: Code-Review+1 > > (2 comments) > > Nice patch Mihaly! http://gerrit.cloudera.org:8080/#/c/21735/6/be/src/exprs/timestamp-functions.cc File be/src/exprs/timestamp-functions.cc: http://gerrit.cloudera.org:8080/#/c/21735/6/be/src/exprs/timestamp-functions.cc@100 PS6, Line 100: const Timezone* GetTimezone(FunctionContext* context, > line too long (91 > 90) Done http://gerrit.cloudera.org:8080/#/c/21735/7/be/src/exprs/timestamp-functions.cc File be/src/exprs/timestamp-functions.cc: http://gerrit.cloudera.org:8080/#/c/21735/7/be/src/exprs/timestamp-functions.cc@100 PS7, Line 100: const Timezone* GetTimezone(FunctionContext* context, > line has trailing whitespace Done http://gerrit.cloudera.org:8080/#/c/21735/7/be/src/exprs/timestamp-functions.cc@112 PS7, Line 112: stringstream ss; > nit: if it's refactored to a separate function, stringstream could be repla Don't mind to replace, but how it's related to whether it's separate function or not? -- To view, visit http://gerrit.cloudera.org:8080/21735 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Icdf5ff82c5d0554333aef1bc3bba034a4cf48230 Gerrit-Change-Number: 21735 Gerrit-PatchSet: 7 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Thu, 05 Sep 2024 15:00:19 +0000 Gerrit-HasComments: Yes
