Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21335 )
Change subject: IMPALA-13022: Added infrastructure for implicit casting of functions ...................................................................... Patch Set 15: (22 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python2 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with virtualenv installed. http://gerrit.cloudera.org:8080/#/c/21335/15/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java: http://gerrit.cloudera.org:8080/#/c/21335/15/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java@208 PS15, Line 208: * The Aggregate RelNode is not allowed to contain a casted expression. line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21335/15/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java@312 PS15, Line 312: int nColumns = values.getRowType().getFieldList().size(); line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21335/15/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java@361 PS15, Line 361: return LogicalProject.create(values, new ArrayList<>(), projects, values.getRowType().getFieldNames()); line too long (107 > 90) http://gerrit.cloudera.org:8080/#/c/21335/15/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java@373 PS15, Line 373: CoerceOperandShuttle shuttle = new CoerceOperandShuttle(relNode.getCluster().getTypeFactory(), line too long (98 > 90) http://gerrit.cloudera.org:8080/#/c/21335/15/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java@396 PS15, Line 396: * compare 2 datatypes and return a datatype that line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21335/15/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java@403 PS15, Line 403: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21335/15/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java@589 PS15, Line 589: newOperandTypes.get(i).getSqlTypeName()) || line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21335/15/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java@613 PS15, Line 613: newOperandTypes.get(i).getSqlTypeName()) || line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21335/15/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceNodes.java@635 PS15, Line 635: newOperandTypes.get(i).getSqlTypeName()) || line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21335/15/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java: http://gerrit.cloudera.org:8080/#/c/21335/15/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java@66 PS15, Line 66: protected static final Logger LOG = LoggerFactory.getLogger(CoerceOperandShuttle.class.getName()); line too long (100 > 90) http://gerrit.cloudera.org:8080/#/c/21335/15/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java@81 PS15, Line 81: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21335/15/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java@115 PS15, Line 115: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21335/15/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java@255 PS15, Line 255: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21335/15/java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/RexCallConverter.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/RexCallConverter.java: http://gerrit.cloudera.org:8080/#/c/21335/15/java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/RexCallConverter.java@80 PS15, Line 80: List<RelDataType> argTypes = Lists.transform(rexCall.getOperands(), RexNode::getType); line too long (92 > 90) http://gerrit.cloudera.org:8080/#/c/21335/15/java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/RexCallConverter.java@81 PS15, Line 81: Preconditions.checkState(false, "Could not find function \"" + funcName + "\" in Impala " line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/21335/15/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaValuesRel.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaValuesRel.java: http://gerrit.cloudera.org:8080/#/c/21335/15/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaValuesRel.java@51 PS15, Line 51: protected static final Logger LOG = LoggerFactory.getLogger(ImpalaValuesRel.class.getName()); line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/21335/15/java/calcite-planner/src/main/java/org/apache/impala/calcite/rel/node/ImpalaValuesRel.java@101 PS15, Line 101: line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21335/15/java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeConverter.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeConverter.java: http://gerrit.cloudera.org:8080/#/c/21335/15/java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeConverter.java@352 PS15, Line 352: // line has trailing whitespace http://gerrit.cloudera.org:8080/#/c/21335/15/java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeSystemImpl.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeSystemImpl.java: http://gerrit.cloudera.org:8080/#/c/21335/15/java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeSystemImpl.java@214 PS15, Line 214: // Call out to Impala code to get the correct derived precision on arithmetic operations. line too long (95 > 90) http://gerrit.cloudera.org:8080/#/c/21335/15/java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeSystemImpl.java@252 PS15, Line 252: return deriveArithmeticType(typeFactory, type1, type2, ArithmeticExpr.Operator.MULTIPLY); line too long (93 > 90) http://gerrit.cloudera.org:8080/#/c/21335/15/java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeSystemImpl.java@258 PS15, Line 258: return deriveArithmeticType(typeFactory, type1, type2, ArithmeticExpr.Operator.DIVIDE); line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/21335/15/java/calcite-planner/src/main/java/org/apache/impala/calcite/type/ImpalaTypeSystemImpl.java@279 PS15, Line 279: return typeFactory.createSqlType(SqlTypeName.DECIMAL, resultPrecision, resultScale); line too long (94 > 90) -- To view, visit http://gerrit.cloudera.org:8080/21335 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I13a349673f185463276ad7ddb83f0cfc2d73218c Gerrit-Change-Number: 21335 Gerrit-PatchSet: 15 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Fri, 06 Sep 2024 16:37:27 +0000 Gerrit-HasComments: Yes
