Quanlong Huang has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21796 )

Change subject: IMPALA-13377: Excercise exec_option in 
test_recover_partitions.py
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/21796/3/tests/metadata/test_recover_partitions.py
File tests/metadata/test_recover_partitions.py:

http://gerrit.cloudera.org:8080/#/c/21796/3/tests/metadata/test_recover_partitions.py@69
PS3, Line 69:     OPTIONS = vector.get_value('exec_option')
I see we just use self.client here and all statements use the same query 
options. Maybe we can simply use this:

 self.client.set_configuration(vector.get_value('exec_option'))



--
To view, visit http://gerrit.cloudera.org:8080/21796
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I4e938dd8667937c996854032a1e13184c62d7b48
Gerrit-Change-Number: 21796
Gerrit-PatchSet: 3
Gerrit-Owner: Riza Suminto <[email protected]>
Gerrit-Reviewer: Daniel Becker <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Quanlong Huang <[email protected]>
Gerrit-Reviewer: Riza Suminto <[email protected]>
Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]>
Gerrit-Comment-Date: Thu, 19 Sep 2024 02:28:46 +0000
Gerrit-HasComments: Yes

Reply via email to