Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/21825 )
Change subject: IMPALA-889: Add trim() function matching ANSI SQL definition ...................................................................... Patch Set 3: (3 comments) gerrit-auto-critic failed. You can reproduce it locally using command: python2 bin/jenkins/critique-gerrit-review.py --dryrun To run it, you might need a virtual env with virtualenv installed. http://gerrit.cloudera.org:8080/#/c/21825/3/fe/src/main/java/org/apache/impala/analysis/TrimFromExpr.java File fe/src/main/java/org/apache/impala/analysis/TrimFromExpr.java: http://gerrit.cloudera.org:8080/#/c/21825/3/fe/src/main/java/org/apache/impala/analysis/TrimFromExpr.java@107 PS3, Line 107: throw new AnalysisException("Function " + trimFromFnName_.getFunction().toUpperCase() line too long (91 > 90) http://gerrit.cloudera.org:8080/#/c/21825/3/fe/src/main/java/org/apache/impala/analysis/TrimFromExpr.java@110 PS3, Line 110: if ((trimFromFnName_.getDb() != null) && !trimFromFnName_.getDb().equals(BuiltinsDb.NAME)) { line too long (96 > 90) http://gerrit.cloudera.org:8080/#/c/21825/3/fe/src/main/java/org/apache/impala/analysis/TrimFromExpr.java@120 PS3, Line 120: } line has trailing whitespace -- To view, visit http://gerrit.cloudera.org:8080/21825 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3c4fa6d0d8d0684c4b6d8dac8fd531d205e4f7b4 Gerrit-Change-Number: 21825 Gerrit-PatchSet: 3 Gerrit-Owner: Mihaly Szjatinya <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Comment-Date: Sat, 21 Sep 2024 12:13:13 +0000 Gerrit-HasComments: Yes
