Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/21847 )
Change subject: IMPALA-11265: Part1: Clear GroupContentFiles once used ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/21847/1/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java File fe/src/main/java/org/apache/impala/catalog/IcebergTable.java: http://gerrit.cloudera.org:8080/#/c/21847/1/fe/src/main/java/org/apache/impala/catalog/IcebergTable.java@427 PS1, Line 427: // We no longer need to keep Iceberg's content files in memory. : icebergFiles.clear(); > Unsetting 'icebergFiles_' seems better to me because having an empty 'icebe Actually, can't we get rid of the 'icebergFiles_' member in HdfsTable if it is only used for a short timeframe? We could pass it to the function(s) that use it as an argument. -- To view, visit http://gerrit.cloudera.org:8080/21847 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1efdd2a46c9675f7461535259e5892ed213a6b21 Gerrit-Change-Number: 21847 Gerrit-PatchSet: 1 Gerrit-Owner: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 24 Sep 2024 15:27:22 +0000 Gerrit-HasComments: Yes
