Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21684 )
Change subject: IMPALA-13302: Restore registering all conjuncts ...................................................................... Patch Set 9: (3 comments) http://gerrit.cloudera.org:8080/#/c/21684/7/testdata/workloads/functional-planner/queries/PlannerTest/rewrite.test File testdata/workloads/functional-planner/queries/PlannerTest/rewrite.test: http://gerrit.cloudera.org:8080/#/c/21684/7/testdata/workloads/functional-planner/queries/PlannerTest/rewrite.test@1 PS7, Line 1: # IMPALA-13302: ExtractCommonConjunctRule led to non-materialized slot > nit: When this test fail, I see following error: Done http://gerrit.cloudera.org:8080/#/c/21684/7/testdata/workloads/functional-planner/queries/PlannerTest/rewrite.test@3 PS7, Line 3: WHERE ((t.id = 1 and false) > nit: Break the predicates in multiple line to clearly show the duplicates. Done http://gerrit.cloudera.org:8080/#/c/21684/7/testdata/workloads/functional-planner/queries/PlannerTest/rewrite.test@43 PS7, Line 43: ==== > nit: Break the predicates in multiple line to clearly show the duplicates. Done -- To view, visit http://gerrit.cloudera.org:8080/21684 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5959a3b3e18302e00b1d37e5f50410ebdb224cb0 Gerrit-Change-Number: 21684 Gerrit-PatchSet: 9 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Tue, 24 Sep 2024 17:24:05 +0000 Gerrit-HasComments: Yes
