Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21335 )
Change subject: IMPALA-13022: Added infrastructure for implicit casting of functions ...................................................................... Patch Set 24: > So just a note regarding the 2 queries you tried. I tried them > with my latest release which has a lot of fixes which I've run on > the test framework. > > For issue 1): This still shows up in my latest copy. So that > means that I haven't hit a test that contains this yet. Is this a > test that you picked out from somewhere? Or did you make this one > up? If it is the former, then yeah, we'll hit this in testing. If > it's the latter, then this is a new test we'll have to put in. > > For issue 2): This looks fixed in my latest copy, so this one > should be fixed soon and was caught by the test framework. I think > the IN clause doesn't totally work properly at this point. The second one is from query_test/test_exprs.py::TestExprs: https://github.com/apache/impala/blob/master/testdata/workloads/functional-query/queries/QueryTest/exprs.test#L994-L995 The 1st statement is a simplification. IN gets translated to a CASE statement. If I remove the "+ 1" like this: select month, tinyint_col, int_col, float_col FROM functional.alltypestiny WHERE month IN (cast(tinyint_col as decimal(34,0)), int_col, 12345, float_col); Then, Impala returns float and Calcite returns double. -- To view, visit http://gerrit.cloudera.org:8080/21335 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I13a349673f185463276ad7ddb83f0cfc2d73218c Gerrit-Change-Number: 21335 Gerrit-PatchSet: 24 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Tue, 24 Sep 2024 23:26:13 +0000 Gerrit-HasComments: No
