Hello Laszlo Gaal, Impala Public Jenkins,

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/21849

to look at the new patch set (#4).

Change subject: IMPALA-13384: Only install gcovr deps for coverage builds
......................................................................

IMPALA-13384: Only install gcovr deps for coverage builds

IMPALA-13279 upgraded gcovr to 7.2 and moved it from python 2 to
python 3.8. gcovr has several dependencies that require native
compilation, and this increased the cost of initializing the
Python 3 virtualenv substantially:

Without gcovr: 1m43.279s
With gcovr and deps: 6m35.107s

This moves gcovr to its own requirements file and only installs
gcovr if this is a coverage build (detected from the
.cmake_buid_type file).

Testing:
 - Verified that a coverage build does install gcovr and
   produce a report

Change-Id: I1d0fd6d21273053aaf2acee39fcb83d9093d49a2
---
M infra/python/bootstrap_virtualenv.py
A infra/python/deps/gcovr-requirements.txt
M infra/python/deps/pip_download.py
M infra/python/deps/py3-requirements.txt
4 files changed, 69 insertions(+), 11 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/49/21849/4
--
To view, visit http://gerrit.cloudera.org:8080/21849
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I1d0fd6d21273053aaf2acee39fcb83d9093d49a2
Gerrit-Change-Number: 21849
Gerrit-PatchSet: 4
Gerrit-Owner: Joe McDonnell <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Laszlo Gaal <[email protected]>

Reply via email to