Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21857 )
Change subject: IMPALA-13181: Disable tuple caching for locations with limits ...................................................................... Patch Set 1: (3 comments) http://gerrit.cloudera.org:8080/#/c/21857/1//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21857/1//COMMIT_MSG@12 PS1, Line 12: refined the rule to allow caching in locations that are Is it non-trivial to determine if the input is sorted? http://gerrit.cloudera.org:8080/#/c/21857/1/fe/src/test/java/org/apache/impala/planner/TupleCacheTest.java File fe/src/test/java/org/apache/impala/planner/TupleCacheTest.java: http://gerrit.cloudera.org:8080/#/c/21857/1/fe/src/test/java/org/apache/impala/planner/TupleCacheTest.java@93 PS1, Line 93: verifyCacheEligible( Could this be implemented as verifyIdenticalCacheKeys( "select a.id from functional.alltypes a, functional.alltypes b" "select a.id from functional.alltypes a, functional.alltypes b limit 10") Seems like a stronger test. http://gerrit.cloudera.org:8080/#/c/21857/1/fe/src/test/java/org/apache/impala/planner/TupleCacheTest.java@95 PS1, Line 95: // A limit on the probe side doesn't impact eligibility on the build side. Should this be part of testCacheKeyGenerality? -- To view, visit http://gerrit.cloudera.org:8080/21857 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Iedcb73082325f1dfe397fbda07c2b7b4817efa5e Gerrit-Change-Number: 21857 Gerrit-PatchSet: 1 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Thu, 26 Sep 2024 21:36:19 +0000 Gerrit-HasComments: Yes
