Riza Suminto has posted comments on this change. ( http://gerrit.cloudera.org:8080/21859 )
Change subject: IMPALA-13402: Clean up test_tuple_cache dimensions ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/21859/1/tests/custom_cluster/test_tuple_cache.py File tests/custom_cluster/test_tuple_cache.py: http://gerrit.cloudera.org:8080/#/c/21859/1/tests/custom_cluster/test_tuple_cache.py@25 PS1, Line 25: (add_exec_option_dimension, nit: line break after parenthesis to save space. http://gerrit.cloudera.org:8080/#/c/21859/1/tests/custom_cluster/test_tuple_cache.py@135 PS1, Line 135: self.client.set_configuration(vector.get_value('exec_option')) This is redundant with L132. -- To view, visit http://gerrit.cloudera.org:8080/21859 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib241f1f1cfaf918dffaddd5aeef3884c70e0a3fb Gerrit-Change-Number: 21859 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Fri, 27 Sep 2024 01:12:36 +0000 Gerrit-HasComments: Yes
