Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21729 )
Change subject: IMPALA-13185: Include runtime filter source in key ...................................................................... Patch Set 12: (4 comments) http://gerrit.cloudera.org:8080/#/c/21729/9/fe/src/main/java/org/apache/impala/planner/TupleCacheInfo.java File fe/src/main/java/org/apache/impala/planner/TupleCacheInfo.java: http://gerrit.cloudera.org:8080/#/c/21729/9/fe/src/main/java/org/apache/impala/planner/TupleCacheInfo.java@228 PS9, Line 228: } : if (orig.isSetSplit_specs()) { : f > This seems complicated to test. Maybe something like this: That didn't trigger partition spec. It did expose that reloading partitions can result in a different order for concrete_ranges; sorting them makes it more stable. http://gerrit.cloudera.org:8080/#/c/21729/5/fe/src/test/java/org/apache/impala/planner/TupleCacheTest.java File fe/src/test/java/org/apache/impala/planner/TupleCacheTest.java: http://gerrit.cloudera.org:8080/#/c/21729/5/fe/src/test/java/org/apache/impala/planner/TupleCacheTest.java@85 PS5, Line 85: // Different filter slot > To get a bushy plan like that with straight_join, we can use a subquery: Done http://gerrit.cloudera.org:8080/#/c/21729/5/fe/src/test/java/org/apache/impala/planner/TupleCacheTest.java@139 PS5, Line 139: // verifyCacheIneligible( > About whether tests belong in this function: It's vague, but I would keep t Ack http://gerrit.cloudera.org:8080/#/c/21729/11/fe/src/test/java/org/apache/impala/planner/TupleCacheTest.java File fe/src/test/java/org/apache/impala/planner/TupleCacheTest.java: http://gerrit.cloudera.org:8080/#/c/21729/11/fe/src/test/java/org/apache/impala/planner/TupleCacheTest.java@70 PS11, Line 70: String basicJoinTmpl = "select straight_join probe.id from functional.alltypes " + : "probe, functional.alltypestiny build where %s"; : verifyIdenticalCacheKeys( : String.format(basicJoinTmpl, "probe.id = build.id"), : String.format(basicJoinTmpl, "probe.id = build.id" > What do you think about using String.format()? i.e. Did something like that. -- To view, visit http://gerrit.cloudera.org:8080/21729 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I0077964be5acdb588d76251a6a39e57a0f42bb5a Gerrit-Change-Number: 21729 Gerrit-PatchSet: 12 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Wed, 02 Oct 2024 19:27:01 +0000 Gerrit-HasComments: Yes
