Tim Armstrong has posted comments on this change. ( http://gerrit.cloudera.org:8080/10410 )
Change subject: IMPALA-7025: ignore resources in some planner test ...................................................................... Patch Set 2: (1 comment) http://gerrit.cloudera.org:8080/#/c/10410/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/10410/2//COMMIT_MSG@13 PS2, Line 13: Instead of trying to tweak the test to avoid the issue, instead provide > Why not ignore them everywhere instead of the tests that are specifically d We need to test the values in the tests that are meant to validate the resource calculations. We will need to tweak or design those tests so that they're robust to slight changes in file size or data layout, but this approach means we don't need to tweak tests like testTableSample unnecessarily. Or are you saying that we should whitelist tests that are explicitly checking them? -- To view, visit http://gerrit.cloudera.org:8080/10410 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I91e3e416ec6242fbf22d9f566fdd1ce225cb16ac Gerrit-Change-Number: 10410 Gerrit-PatchSet: 2 Gerrit-Owner: Tim Armstrong <[email protected]> Gerrit-Reviewer: Alex Behm <[email protected]> Gerrit-Reviewer: Tim Armstrong <[email protected]> Gerrit-Comment-Date: Tue, 15 May 2018 20:07:24 +0000 Gerrit-HasComments: Yes
