Michael Smith has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21729 )
Change subject: IMPALA-13185: Include runtime filter source in key ...................................................................... IMPALA-13185: Include runtime filter source in key Incorporates the build-side PlanNode of a runtime filter in the tuple cache key to avoid re-using intermediate results that were generated using a runtime filter on the same target but different selection criteria (build-side conjuncts). We currently don't support caching ExchangeNode, but a common scenario is a runtime filter produced by a HashJoin, with an Exchange on the build side. Looks through the first ExchangeNode when considering the cache key and eligibility for the build side source for a runtime filter. Testing shows all tests now passing for test_tuple_cache_tpc_queries except those that hit "TupleCacheNode does not enforce limits itself and cannot have a limit set." Adds planner tests covering some scenarios where runtime filters are expected to match or differ, and custom cluster tests for multi-node testing. Change-Id: I0077964be5acdb588d76251a6a39e57a0f42bb5a Reviewed-on: http://gerrit.cloudera.org:8080/21729 Tested-by: Impala Public Jenkins <[email protected]> Reviewed-by: Joe McDonnell <[email protected]> --- M fe/src/main/java/org/apache/impala/planner/JoinBuildSink.java M fe/src/main/java/org/apache/impala/planner/JoinNode.java M fe/src/main/java/org/apache/impala/planner/PlanNode.java M fe/src/main/java/org/apache/impala/planner/RuntimeFilterGenerator.java M fe/src/main/java/org/apache/impala/planner/TupleCacheInfo.java M fe/src/test/java/org/apache/impala/planner/TupleCacheTest.java M tests/custom_cluster/test_tuple_cache.py 7 files changed, 395 insertions(+), 33 deletions(-) Approvals: Impala Public Jenkins: Verified Joe McDonnell: Looks good to me, approved -- To view, visit http://gerrit.cloudera.org:8080/21729 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I0077964be5acdb588d76251a6a39e57a0f42bb5a Gerrit-Change-Number: 21729 Gerrit-PatchSet: 14 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]>
