Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21698 )
Change subject: IMPALA-13186: Tag query option scope for tuple cache ...................................................................... Patch Set 11: (1 comment) Let's say that we have low cache hit rates. Is there a way we could tell whether it is related to different query options? Do we want a way to tune this at startup (i.e. a list of additional query options to exempt)? If we wanted an approximation of how many distinct query option hashes there are, we could maintain an HLL sketch. http://gerrit.cloudera.org:8080/#/c/21698/11/fe/src/main/java/org/apache/impala/planner/PlanNode.java File fe/src/main/java/org/apache/impala/planner/PlanNode.java: http://gerrit.cloudera.org:8080/#/c/21698/11/fe/src/main/java/org/apache/impala/planner/PlanNode.java@1388 PS11, Line 1388: tupleCacheInfo_.hashThrift(queryOptsHash); Nit: What do you think about incorporating it once (i.e. at leaf nodes) and then skipping it for higher up the tree? -- To view, visit http://gerrit.cloudera.org:8080/21698 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1f4802ad9548749cd43df8848b6f46dca3739ae7 Gerrit-Change-Number: 21698 Gerrit-PatchSet: 11 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Kurt Deschler <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Sat, 05 Oct 2024 00:00:36 +0000 Gerrit-HasComments: Yes
