Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21865 )
Change subject: IMPALA-13407: Codegen fails with struct in TOP-N ...................................................................... IMPALA-13407: Codegen fails with struct in TOP-N The following query succeeded with codegen disabled but failed with codegen enabled: use functional_parquet; select str, alltypes from complextypes_structs order by str limit 4; The root cause is the handling of CHARs in CodegenAnyVal::StructChildToReadWriteInfo(). The code assumed that CHARs could be handled the same way as STRINGs and VARCHARs but this is incorrect. This patch fixes it by adding CHAR-specific handling. Testing: - added test queries to top-n-complex.test and also sort-complex.test for consistency - cleanup: moved one test with a LIMIT clause from sort-complex.test to top-n-complex.test; also brought the two test files in sync by adding counterparts to queries with and without LIMIT clauses in the other file where they were missing. Change-Id: I25c3ad73dea062a0de2402c20f39097625fbb2c8 Reviewed-on: http://gerrit.cloudera.org:8080/21865 Reviewed-by: Impala Public Jenkins <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M be/src/codegen/codegen-anyval.cc M testdata/workloads/functional-query/queries/QueryTest/sort-complex.test M testdata/workloads/functional-query/queries/QueryTest/top-n-complex.test 3 files changed, 99 insertions(+), 13 deletions(-) Approvals: Impala Public Jenkins: Looks good to me, approved; Verified -- To view, visit http://gerrit.cloudera.org:8080/21865 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I25c3ad73dea062a0de2402c20f39097625fbb2c8 Gerrit-Change-Number: 21865 Gerrit-PatchSet: 4 Gerrit-Owner: Daniel Becker <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]>
