Yida Wu has posted comments on this change. ( http://gerrit.cloudera.org:8080/21898 )
Change subject: IMPALA-12908: (Addendum) use RUNTIME_FILTER_WAIT_TIME_MS for tuple cache TPC testing ...................................................................... Patch Set 2: (2 comments) Changed the enable_tuple_cache_verification to false by default, and do correctness check only when the testcase enables it to avoid potential flaky tests due to the runtime filters. http://gerrit.cloudera.org:8080/#/c/21898/2/common/thrift/Query.thrift File common/thrift/Query.thrift: PS2: > This file is used in communication between impalad and catalogd/statestore. Only changed the default value for a debugging query option. It should be fine http://gerrit.cloudera.org:8080/#/c/21898/1/tests/query_test/test_tuple_cache_tpc_queries.py File tests/query_test/test_tuple_cache_tpc_queries.py: http://gerrit.cloudera.org:8080/#/c/21898/1/tests/query_test/test_tuple_cache_tpc_queries.py@33 PS1, Line 33: # Use a long runtime filter wait time (1 minute) to ensure filters arrive before > I assume it never waits anything near 10 minutes? Changed to 1 minute. The idea is to set a value long enough without causing any troubles during testing. Seems to work fine in the tests. -- To view, visit http://gerrit.cloudera.org:8080/21898 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ie70a87344c436ce8e2073575df5c5bf762ef562d Gerrit-Change-Number: 21898 Gerrit-PatchSet: 2 Gerrit-Owner: Yida Wu <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Yida Wu <[email protected]> Gerrit-Comment-Date: Mon, 07 Oct 2024 17:02:05 +0000 Gerrit-HasComments: Yes
