Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/21897 )
Change subject: IMPALA-13197: (part 2) Added Analytic Expressions to Calcite Planner ...................................................................... Patch Set 2: Code-Review+1 (3 comments) This fixes the crashes I was seeing. The logic makes sense to me, just some minor style questions. http://gerrit.cloudera.org:8080/#/c/21897/2//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21897/2//COMMIT_MSG@19 PS2, Line 19: TODO: file Jira or change the code here Do something with this TODO http://gerrit.cloudera.org:8080/#/c/21897/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/AnalyzedAnalyticExpr.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/AnalyzedAnalyticExpr.java: http://gerrit.cloudera.org:8080/#/c/21897/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/AnalyzedAnalyticExpr.java@77 PS2, Line 77: private boolean isResetNeeded(String fname) { : return fname.equals("lag") || fname.equals("lead"); : } Nit: Would it be possible to use isOffsetFn()? http://gerrit.cloudera.org:8080/#/c/21897/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/AnalyzedFunctionCallExpr.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/AnalyzedFunctionCallExpr.java: http://gerrit.cloudera.org:8080/#/c/21897/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/functions/AnalyzedFunctionCallExpr.java@106 PS2, Line 106: public void resetFunction() throws ImpalaException { Nit: If we don't think we'll need this for other functions, we could make this function name more specific (e.g. resetAnalyticOffsetFn() or something like that). -- To view, visit http://gerrit.cloudera.org:8080/21897 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I56529b13c545cdc9f96dd1c3bea9ef676e8c2755 Gerrit-Change-Number: 21897 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Wed, 09 Oct 2024 21:28:15 +0000 Gerrit-HasComments: Yes
