Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21718 )
Change subject: IMPALA-13325: Use RowBatch::CopyRows in IcebergDeleteNode ...................................................................... Patch Set 5: (1 comment) http://gerrit.cloudera.org:8080/#/c/21718/5/be/src/exec/iceberg-delete-node.cc File be/src/exec/iceberg-delete-node.cc: http://gerrit.cloudera.org:8080/#/c/21718/5/be/src/exec/iceberg-delete-node.cc@309 PS5, Line 309: auto NextProbePos = [this, &probe_it]() { > I am a bit confused about this function - does it return the position of th Yes, it does. The iterator shouldn't go beyond the end of the row batch because of 'rows_to_copy_max'. -- To view, visit http://gerrit.cloudera.org:8080/21718 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I46487fefa300027e9df6cd7fb36c78af01dd56c1 Gerrit-Change-Number: 21718 Gerrit-PatchSet: 5 Gerrit-Owner: Zoltan Borok-Nagy <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Thu, 10 Oct 2024 08:55:44 +0000 Gerrit-HasComments: Yes
