Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21922 )

Change subject: IMPALA-13438  Batch the `addHmsPartitions` operations in 
`alterTableRecoverPartitions`.
......................................................................


Patch Set 1:

(1 comment)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python2 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with virtualenv installed.

http://gerrit.cloudera.org:8080/#/c/21922/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java:

http://gerrit.cloudera.org:8080/#/c/21922/1/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@6329
PS1, Line 6329:       for (List<Partition> hmsSublist : 
Lists.partition(hmsPartitions, MAX_PARTITION_ADDS_PER_BATCH)) {
line too long (103 > 90)



--
To view, visit http://gerrit.cloudera.org:8080/21922
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I13aaad8a915f75fbe808bf96b1cf891312b1a592
Gerrit-Change-Number: 21922
Gerrit-PatchSet: 1
Gerrit-Owner: zhangqianqiong <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Comment-Date: Fri, 11 Oct 2024 10:09:12 +0000
Gerrit-HasComments: Yes

Reply via email to