Impala Public Jenkins has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21600 )

Change subject: IMPALA-13440: Calcite ParserTest changes
......................................................................


Patch Set 6:

(174 comments)

gerrit-auto-critic failed. You can reproduce it locally using command:

  python2 bin/jenkins/critique-gerrit-review.py --dryrun

To run it, you might need a virtual env with virtualenv installed.

http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java
File fe/src/test/java/org/apache/impala/analysis/ParserTest.java:

http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@57
PS6, Line 57:     helper.ParsesOk("copy testcase to 'hdfs:///foo' with v as 
(select 1) select * from v");
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@58
PS6, Line 58:     helper.ParsesOk("copy testcase to 'hdfs:///foo' select * from 
t1 union select * from t2");
line too long (94 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@60
PS6, Line 60:     helper.ParserError("copy testcase to 'hdfs:///foo' alter 
table foo add partition (p=1)");
line too long (93 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@412
PS6, Line 412:     helper.TestSelectListHints("select /* -- +straight_join */ * 
from functional.alltypes",
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@414
PS6, Line 414:     helper.TestSelectListHints("select /* abcdef +straight_join 
*/ * from functional.alltypes",
line too long (95 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@416
PS6, Line 416:     helper.TestSelectListHints("select \n-- abcdef 
+straight_join\n * from functional.alltypes",
line too long (96 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@418
PS6, Line 418:     helper.TestSelectListHints("select \n-- /*+straight_join\n * 
from functional.alltypes",
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@438
PS6, Line 438:     helper.TestSelectListHints("select /* +straight_join, ,, */ 
* from functional.alltypes",
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@551
PS6, Line 551:             helper.ParsesOk(String.format("select * from %s %s 
%s %s", tbl, alias, smp, hint));
line too long (95 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@656
PS6, Line 656:     helper.ParsesOk("select count(c) from test group by a having 
if (a > b, true, false)");
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@662
PS6, Line 662:     helper.ParserError("select a, b, count(c) from test having 
count(*) > 5 group by a, b");
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@712
PS6, Line 712:       helper.ParserError(String.format("select a from test %s 
all select a from test", noAllOp));
line too long (97 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@727
PS6, Line 727:       helper.ParsesOk(String.format("select a from test %s 
distinct select a from test", op));
line too long (94 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@801
PS6, Line 801:       helper.ParsesOk(String.format("select a from test order by 
a %s select a from test", op));
line too long (96 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@804
PS6, Line 804:       helper.ParsesOk(String.format("select a from test offset 5 
%s select a from test", op));
line too long (94 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@865
PS6, Line 865:     helper.ParsesOk("select * from (values(1, abc), ('x', cde), 
(2), (efg, fgh, ghi)) as t");
line too long (93 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@935
PS6, Line 935:     helper.ParsesOk("with `t1` as (select 1 a), 't2' as (select 
2 a), \"t3\" as (select 3 a)" +
line too long (95 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@946
PS6, Line 946:     helper.ParsesOk("with t as (select 1) insert into x with t 
as (select 2) select * from t");
line too long (95 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@950
PS6, Line 950:     helper.ParsesOk("with t as (select 1) upsert into x with t 
as (select 2) select * from t");
line too long (95 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@1068
PS6, Line 1068:     helper.ParsesOk("select `select`, `insert`, `upsert` from 
`table` where `where` = 10");
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@1367
PS6, Line 1367:     helper.ParsesOk("select case when a > 2 then x when false 
then false else true end from t");
line too long (96 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@1368
PS6, Line 1368:     helper.ParsesOk("select case false when a > 2 then x when 
'6' then false else true end " +
line too long (94 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@1371
PS6, Line 1371:     helper.ParsesOk("select case NULL when NULL then NULL when 
NULL then NULL else NULL end " +
line too long (95 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@1373
PS6, Line 1373:     helper.ParsesOk("select case when NULL then NULL when NULL 
then NULL else NULL end from t");
line too long (96 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@1438
PS6, Line 1438:     helper.ParsesOk("select 2 * x, sum(v) over (partition by a, 
2*b order by 3*c rows between "
line too long (95 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@1513
PS6, Line 1513:     helper.ParserError("select a, b, c from t where " + notStr 
+ "(a = 5) " + orStr + " " + notStr);
line too long (100 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@1558
PS6, Line 1558:     helper.ParsesOk("select a, b, c from t where 'abc' between 
'a' like 'a' and 'b' like 'b'");
line too long (95 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@1563
PS6, Line 1563:     helper.ParsesOk("select a, b, c from t where i between x 
and (y and (true and false))");
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@1652
PS6, Line 1652:         helper.ParsesOk(String.format("insert %s %s t partition 
(pk1=abc, pk2=(5*8+10)) " +
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@1666
PS6, Line 1666:         helper.ParsesOk(String.format("insert %s %s t(a,b,c) 
partition(d) values(1,2,3,4)",
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@1738
PS6, Line 1738:       helper.ParsesOk(String.format("upsert into %s t (a,b,c) 
values(1,2,3,4,5,6)", optTbl));
line too long (93 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@1744
PS6, Line 1744:       helper.ParsesOk(String.format("with x as (select a from 
src where b > 5) upsert into %s " +
line too long (97 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@1750
PS6, Line 1750:       helper.ParserError(String.format("upsert %s t select a 
from src where b > 5", optTbl));
line too long (93 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@1752
PS6, Line 1752:       helper.ParserError(String.format("upsert into %s select a 
from src where b > 5", optTbl));
line too long (96 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@1760
PS6, Line 1760:       helper.ParserError(String.format("upsert ignore into %s t 
select a from src", optTbl));
line too long (93 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@1765
PS6, Line 1765:       helper.ParserError(String.format("upsert overwrite %s t 
select 1 from src", optTbl));
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@1787
PS6, Line 1787:     helper.ParserError("update (select * from 
functional_kudu.testtbl) a set name = '10'");
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2054
PS6, Line 2054:       helper.ParserError(String.format("CREATE %s Foo COMMENT 
LOCATION '/hdfs_location'", kw));
line too long (95 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2069
PS6, Line 2069:     helper.ParsesOk("CREATE FUNCTION Foo() RETURNS INT LOCATION 
'f.jar' SYMBOL='class.Udf'");
line too long (93 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2076
PS6, Line 2076:     helper.ParsesOk("CREATE FUNCTION IF NOT EXISTS Foo() 
RETURNS INT LOCATION 'foo.jar' " +
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2080
PS6, Line 2080:     helper.ParsesOk("CREATE FUNCTION IF NOT EXISTS foo LOCATION 
'f.jar' SYMBOL='class.Udf'");
line too long (93 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2081
PS6, Line 2081:     helper.ParsesOk("CREATE FUNCTION IF NOT EXISTS db.foo 
LOCATION 'f.jar' SYMBOL='class.Udf'");
line too long (96 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2106
PS6, Line 2106:     helper.ParserError("CREATE FUNCTION Foo() RETURNS INT 
LOCATION 'a' SYMBOL='1' SYMBOL='2'");
line too long (95 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2107
PS6, Line 2107:     helper.ParserError("CREATE FUNCTION IF NOT EXISTS db.foo 
LOCATION 'f.jar' SYMBOL='1'" +
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2149
PS6, Line 2149:     helper.ParsesOk(c + loc + "merge_fn='M' Init_fn='I' 
serialize_fn='S' Finalize_fn='F'");
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2150
PS6, Line 2150:     helper.ParsesOk(c + loc + "Init_fn='M' Finalize_fn='I' 
merge_fn='S' serialize_fn='F'");
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2180
PS6, Line 2180:       helper.ParsesOk(String.format("ALTER TABLE TestDb.Foo ADD 
COLUMN %s i int", keyword));
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2184
PS6, Line 2184:       helper.ParserError(String.format("ALTER TABLE TestDb.Foo 
ADD COLUMN %s (i int)", keyword));
line too long (97 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2204
PS6, Line 2204:       helper.ParsesOk(String.format("ALTER TABLE Foo %s COLUMNS 
(i int PRIMARY KEY NOT NULL " +
line too long (95 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2210
PS6, Line 2210:       helper.ParserError(String.format("ALTER TABLE TestDb.Foo 
%s COLUMNS i int", addReplace));
line too long (95 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2215
PS6, Line 2215:       helper.ParserError(String.format("ALTER TestDb.Foo %s 
COLUMNS (i int)", addReplace));
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2218
PS6, Line 2218:       helper.ParserError(String.format("ALTER Foo %s COLUMNS (i 
int, s string)", addReplace));
line too long (94 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2219
PS6, Line 2219:       helper.ParserError(String.format("ALTER TABLE %s COLUMNS 
(i int, s string)", addReplace));
line too long (96 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2226
PS6, Line 2226:     helper.ParsesOk("ALTER TABLE TestDb.Foo ADD IF NOT EXISTS 
PARTITION (i=1, s='Hello')");
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2227
PS6, Line 2227:     helper.ParsesOk("ALTER TABLE TestDb.Foo ADD PARTITION (i=1, 
s='Hello') LOCATION '/a/b'");
line too long (93 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2230
PS6, Line 2230:     helper.ParsesOk("ALTER TABLE Foo ADD PARTITION (i=abc, 
j=(5*8+10), k=!true and false)");
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2236
PS6, Line 2236:     helper.ParsesOk("ALTER TABLE TestDb.Foo ADD PARTITION (i=1, 
s='one') LOCATION 'a/b' " +
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2248
PS6, Line 2248:     helper.ParserError("ALTER TABLE TestDb.Foo ADD PARTITION 
(i=1, s='Hello') LOCATION a/b");
line too long (93 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2255
PS6, Line 2255:     helper.ParsesOk("ALTER TABLE Foo ADD PARTITION (j=2) CACHED 
IN 'pool' WITH replication = 3");
line too long (97 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2260
PS6, Line 2260:     helper.ParsesOk("ALTER TABLE Foo ADD PARTITION (j=2) 
LOCATION 'a/b' CACHED IN 'pool'");
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2261
PS6, Line 2261:     helper.ParsesOk("ALTER TABLE Foo ADD PARTITION (j=2) 
LOCATION 'a/b' CACHED IN 'pool' " +
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2263
PS6, Line 2263:     helper.ParserError("ALTER TABLE Foo ADD PARTITION (j=2) 
CACHED IN 'pool' LOCATION 'a/b'");
line too long (94 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2288
PS6, Line 2288:       helper.ParsesOk(String.format("ALTER TABLE Foo ADD %s 
RANGE PARTITION 10 < VALUES < 20",
line too long (94 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2292
PS6, Line 2292:       helper.ParserError(String.format("ALTER TABLE Foo ADD %s 
RANGE PARTITION 10 < VALUES " +
line too long (94 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2294
PS6, Line 2294:       helper.ParserError(String.format("ALTER TABLE Foo ADD %s 
(RANGE PARTITION 10 < VALUES " +
line too long (95 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2365
PS6, Line 2365:       helper.ParserError(String.format("ALTER TABLE TestDb.Foo 
DROP (i=1, s='Hello') %s", kw));
line too long (95 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2370
PS6, Line 2370:       helper.ParserError(String.format("ALTER TABLE TestDb.Foo 
DROP PARTITION () %s", kw));
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2378
PS6, Line 2378:       helper.ParsesOk(String.format("ALTER TABLE Foo DROP %s 
RANGE PARTITION 10 < VALUES < 20",
line too long (95 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2382
PS6, Line 2382:       helper.ParserError(String.format("ALTER TABLE Foo DROP %s 
RANGE PARTITION 10 < VALUES " +
line too long (95 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2384
PS6, Line 2384:       helper.ParserError(String.format("ALTER TABLE Foo DROP %s 
(RANGE PARTITION 10 < VALUES " +
line too long (96 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2386
PS6, Line 2386:       helper.ParserError(String.format("ALTER TABLE Foo DROP %s 
RANGE PARTITION VALUE = 100 " +
line too long (95 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2397
PS6, Line 2397:       helper.ParsesOk(String.format("ALTER TABLE Foo CHANGE %s 
c1 c2 int comment 'hi'", kw));
line too long (93 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2430
PS6, Line 2430:     helper.ParsesOk("ALTER TABLE Foo PARTITION (i=1,s='str') 
SET LOCATION '/a/i=1/s=str'");
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2466
PS6, Line 2466:         helper.ParsesOk(String.format("ALTER TABLE Foo %s SET 
%s ('a'='b')", part, propType));
line too long (94 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2471
PS6, Line 2471:         helper.ParsesOk(String.format("ALTER TABLE Foo %s SET 
%s ('a'='1', 'b'='2', 'c'='3')",
line too long (94 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2473
PS6, Line 2473:         helper.ParserError(String.format("ALTER TABLE Foo %s 
SET %s ( )", part, propType));
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2478
PS6, Line 2478:         helper.ParserError(String.format("ALTER TABLE Foo %s 
SET %s ('a'=b)", part, propType));
line too long (95 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2479
PS6, Line 2479:         helper.ParserError(String.format("ALTER TABLE Foo %s 
SET %s (a='b')", part, propType));
line too long (95 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2480
PS6, Line 2480:         helper.ParserError(String.format("ALTER TABLE Foo %s 
SET %s (a=b)", part, propType));
line too long (93 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2486
PS6, Line 2486:     helper.ParsesOk("ALTER TABLE Foo SET COLUMN STATS col 
('numDVs'='10','maxSize'='20')");
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2489
PS6, Line 2489:     helper.ParsesOk("ALTER TABLE Foo SET COLUMN STATS col 
('NUM_TRUES'='10','NUM_FALSES'='20')");
line too long (97 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2497
PS6, Line 2497:     helper.ParserError("ALTER TABLE Foo PARTITION (p=1) SET 
COLUMN STATS col ('avgSize'='20')");
line too long (96 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2511
PS6, Line 2511:     helper.ParserError("ALTER TABLE TEST PARTITION (year=2009, 
month=4) SORT BY (int_col, id)");
line too long (96 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2553
PS6, Line 2553:       helper.ParsesOk(String.format("ALTER TABLE foo ALTER %s 
bar SET default 0", column));
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2559
PS6, Line 2559:       helper.ParserError(String.format("ALTER TABLE foo ALTER 
%s bar SET default", column));
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2560
PS6, Line 2560:       helper.ParserError(String.format("ALTER TABLE foo ALTER 
%s bar SET error 0", column));
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2563
PS6, Line 2563:       helper.ParserError(String.format("ALTER TABLE foo ALTER 
%s bar DROP comment", column));
line too long (93 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2591
PS6, Line 2591:     helper.ParsesOk("CREATE EXTERNAL TABLE Foo (i int, s 
string) LOCATION '/test-warehouse/'");
line too long (95 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2592
PS6, Line 2592:     helper.ParsesOk("CREATE TABLE Foo (i int, s string) COMMENT 
'hello' LOCATION '/a/b/'");
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2593
PS6, Line 2593:     helper.ParsesOk("CREATE TABLE Foo (i int, s string) COMMENT 
'hello' LOCATION '/a/b/' " +
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2602
PS6, Line 2602:     helper.ParsesOk("CREATE TABLE Foo (i int, s string) 
PARTITIONED BY (s string, d double)" +
line too long (94 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2624
PS6, Line 2624:     helper.ParserError("CREATE TABLE Foo (i int, s string) 
COMMENT 'hello' LOCATION '/a/b/' " +
line too long (95 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2626
PS6, Line 2626:     helper.ParserError("CREATE TABLE Foo (i int, s string) 
COMMENT 'hello' LOCATION '/a/b/' " +
line too long (95 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2635
PS6, Line 2635:     helper.ParsesOk("CREATE TABLE Foo SORT BY(bar) LIKE Baz 
STORED AS TEXTFILE LOCATION '/a/b'");
line too long (97 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2657
PS6, Line 2657:     helper.ParsesOk("CREATE TABLE Foo (i int, s string) SORT BY 
ZORDER (s) COMMENT 'hello' " +
line too long (94 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2662
PS6, Line 2662:     helper.ParserError("CREATE TABLE Foo (i int, s string) 
COMMENT 'hello' SORT BY ZORDER (s) " +
line too long (97 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2664
PS6, Line 2664:     helper.ParserError("CREATE TABLE Foo (i int, s string) 
COMMENT 'hello' LOCATION '/a/b/' " +
line too long (95 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2666
PS6, Line 2666:     helper.ParserError("CREATE TABLE Foo (i int, s string) 
COMMENT 'hello' LOCATION '/a/b/' " +
line too long (95 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2677
PS6, Line 2677:     helper.ParserError("CREATE TABLE SORT BY ZORDER(bar) Foo 
LIKE Baz STORED AS TEXTFILE " +
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2694
PS6, Line 2694:     helper.ParsesOk("CREATE TABLE T (i int COMMENT 'hi') 
PARTITIONED BY (j int COMMENT 'bye')");
line too long (96 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2710
PS6, Line 2710:       helper.ParserError(String.format("CREATE EXTERNAL TABLE t 
PRIMARY KEYS (i) STORED AS " +
line too long (94 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2718
PS6, Line 2718:     helper.ParsesOk("CREATE TABLE foo (i INT PRIMARY KEY, 
PRIMARY KEY(i)) STORED AS KUDU");
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2719
PS6, Line 2719:     helper.ParsesOk("CREATE TABLE foo (i INT PRIMARY KEY, j INT 
PRIMARY KEY) STORED AS KUDU");
line too long (94 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2730
PS6, Line 2730:     helper.ParserError("CREATE TABLE foo (i INT) NON UNIQUE 
PRIMARY KEY (i) STORED AS KUDU");
line too long (93 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2732
PS6, Line 2732:     helper.ParserError("CREATE TABLE foo (NON UNIQUE PRIMARY 
KEY(a), a INT) STORED AS KUDU");
line too long (93 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2757
PS6, Line 2757:     helper.ParserError("create table foo(id int, year string, 
primary key(id), primary key"
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2768
PS6, Line 2768:     helper.ParserError("create table foo(id int, year int, 
primary key (id, year) novalidate "
line too long (94 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2770
PS6, Line 2770:     helper.ParserError("create table fk(id int, year int, 
foreign key(id) REFERENCES pk(id) "
line too long (93 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2773
PS6, Line 2773:     helper.ParsesOk("create table fk(id int, year string, 
primary key(id), foreign key(id) "
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2808
PS6, Line 2808:     helper.ParsesOk("CREATE TABLE T (i int) ROW FORMAT 
DELIMITED FIELDS TERMINATED BY '|'");
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2809
PS6, Line 2809:     helper.ParsesOk("CREATE TABLE T (i int) ROW FORMAT 
DELIMITED LINES TERMINATED BY '|'");
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2811
PS6, Line 2811:     helper.ParsesOk("CREATE TABLE T (i int) ROW FORMAT 
DELIMITED FIELDS TERMINATED BY '\0'" +
line too long (93 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2813
PS6, Line 2813:     helper.ParsesOk("CREATE TABLE T (i int) ROW FORMAT 
DELIMITED FIELDS TERMINATED BY '\0'" +
line too long (93 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2815
PS6, Line 2815:     helper.ParsesOk("CREATE TABLE T (i int) COMMENT 'hi' ROW 
FORMAT DELIMITED STORED AS RCFILE");
line too long (97 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2816
PS6, Line 2816:     helper.ParsesOk("CREATE TABLE T (i int) COMMENT 'hello' ROW 
FORMAT DELIMITED FIELDS " +
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2821
PS6, Line 2821:     helper.ParserError("CREATE TABLE T (i int) ROW FORMAT 
DELIMITED FIELDS TERMINATED BY");
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2824
PS6, Line 2824:     helper.ParserError("CREATE TABLE T (i int) ROW FORMAT 
DELIMITED FIELDS TERMINATED '|'");
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2825
PS6, Line 2825:     helper.ParserError("CREATE TABLE T (i int) ROW FORMAT 
DELIMITED FIELDS TERMINATED BY |");
line too long (93 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2836
PS6, Line 2836:     helper.ParserError("CREATE TABLE Foo (d double) STORED AS 
TEXTFILE ROW FORMAT DELIMITED");
line too long (94 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2843
PS6, Line 2843:     helper.ParserError("CREATE TABLE Foo (d double) LOCATION 
'a' COMMENT 'c' STORED AS RCFILE");
line too long (96 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2846
PS6, Line 2846:     helper.ParserError("CREATE TABLE Foo (i int) LOCATION 'a' 
WITH SERDEPROPERTIES('a'='b')");
line too long (94 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2852
PS6, Line 2852:     helper.ParserError("CREATE TABLE Foo (d double COMMENT 'c') 
PARTITIONED BY (j COMMENT hi)");
line too long (96 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2868
PS6, Line 2868:     helper.ParserError("CREATE TABLE Foo (i int) PARTITIONED 
BY(j int) CACHED IN 'myPool' " +
line too long (93 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2870
PS6, Line 2870:     helper.ParserError("CREATE TABLE Foo (i int) CACHED IN 
'myPool' WITH REPLICATION = -1");
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2871
PS6, Line 2871:     helper.ParserError("CREATE TABLE Foo (i int) CACHED IN 
'myPool' WITH REPLICATION = 1.0");
line too long (93 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2892
PS6, Line 2892:     helper.ParsesOk("CREATE TABLE Foo (i int, s string) 
PRODUCED BY DATA SOURCE Bar(\"\")");
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2895
PS6, Line 2895:     helper.ParsesOk("CREATE TABLE IF NOT EXISTS Foo (i int) 
PRODUCED BY DATA SOURCE Bar(\"\")");
line too long (96 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2902
PS6, Line 2902:     helper.ParserError("CREATE EXTERNAL TABLE Foo (i int) 
PRODUCED BY DATA SOURCE Foo(\"\")");
line too long (94 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2907
PS6, Line 2907:     helper.ParserError("CREATE TABLE Foo (i int) PARTITIONED BY 
(j string) PRODUCED BY DATA " +
line too long (95 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2988
PS6, Line 2988:               helper.ParsesOk(String.format("CREATE TABLE Foo 
(i int NON UNIQUE PRIMARY KEY " +
line too long (95 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2996
PS6, Line 2996:     helper.ParserError("CREATE TABLE Foo(a int PRIMARY KEY 
ENCODING RLE ENCODING PLAIN) " +
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@2999
PS6, Line 2999:     helper.ParsesOk("CREATE TABLE Foo(a int PRIMARY KEY, b int 
DEFAULT 1+1) STORED AS KUDU");
line too long (93 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3000
PS6, Line 3000:     helper.ParsesOk("CREATE TABLE Foo(a int PRIMARY KEY, b 
float DEFAULT cast(1.1 as float)) " +
line too long (96 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3005
PS6, Line 3005:     helper.ParserError("CREATE TABLE Foo(a int PRIMARY KEY 
BLOCK_SIZE -1) STORED AS KUDU");
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3010
PS6, Line 3010:     helper.ParsesOk("CREATE TABLE bucketed_test (i int COMMENT 
'hello', a int, s string) " +
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3038
PS6, Line 3038:     helper.ParsesOk("CREATE DATA SOURCE foo LOCATION 
\"/foo.jar\" CLASS \"com.bar.Foo\" " +
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3040
PS6, Line 3040:     helper.ParsesOk("CREATE DATA SOURCE foo LOCATION 
'/x/foo@hi_^!#.jar' CLASS 'com.bar.Foo' " +
line too long (96 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3046
PS6, Line 3046:     helper.ParserError("CREATE DATA SRC foo.bar LOCATION 
'/foo.jar' CLASS 'com.bar.Foo' " +
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3048
PS6, Line 3048:     helper.ParserError("CREATE DATA SOURCE foo.bar LOCATION 
'/x/foo.jar' CLASS 'com.bar.Foo' " +
line too long (96 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3054
PS6, Line 3054:     helper.ParserError("CREATE DATA SOURCE foo LOCATION 
'/x/foo.jar' CLASS 'com.bar.Foo' " +
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3061
PS6, Line 3061:     helper.ParserError("CREATE DATA SOURCE foo LOCATION 
'/foo.jar' CLASS API_VERSION 'V1'");
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3063
PS6, Line 3063:     helper.ParserError("CREATE DATA SOURCE foo LOCATION 
'/foo.jar' CLASS 'Foo' API_VERSION");
line too long (93 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3064
PS6, Line 3064:     helper.ParserError("CREATE DATA SOURCE foo CLASS 
'com.bar.Foo' LOCATION '/x/foo.jar' " +
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3094
PS6, Line 3094:     helper.ParsesOk("CREATE VIEW Foo.Bar (x, y, z COMMENT 
'foo') AS SELECT a, b, c from t");
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3095
PS6, Line 3095:     helper.ParsesOk("CREATE VIEW Foo.Bar (x, y, z) COMMENT 
'test' AS SELECT a, b, c from t");
line too long (93 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3107
PS6, Line 3107:     helper.ParsesOk("CREATE VIEW Bar (x, y, z) TBLPROPERTIES 
('a' = 'b') AS SELECT 1, 2, 3");
line too long (93 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3134
PS6, Line 3134:     helper.ParserError("CREATE VIEW Foo.Bar (x) AS ALTER TABLE 
Foo COLUMNS (i int, s string)");
line too long (95 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3139
PS6, Line 3139:     helper.ParserError("CREATE VIEW Bar (x, y, z) TBLPROPERTIES 
(i int) AS SELECT 1, 2, 3");
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3157
PS6, Line 3157:     helper.ParsesOk("ALTER VIEW Foo.Bar (x, y, z COMMENT 'foo') 
AS SELECT a, b, c from t");
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3201
PS6, Line 3201:     helper.ParsesOk("CREATE TABLE IF NOT EXISTS Foo.Bar 
LOCATION '/a/b' AS SELECT * from foo");
line too long (95 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3203
PS6, Line 3203:     helper.ParsesOk("CREATE TABLE Foo ROW FORMAT DELIMITED 
STORED AS PARQUETFILE AS SELECT 1");
line too long (95 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3204
PS6, Line 3204:     helper.ParsesOk("CREATE TABLE Foo TBLPROPERTIES ('a'='b', 
'c'='d') AS SELECT * from bar");
line too long (94 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3206
PS6, Line 3206:     helper.ParsesOk("CREATE TABLE Foo PRIMARY KEY (a, b) 
PARTITION BY HASH PARTITIONS 2 " +
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3208
PS6, Line 3208:     helper.ParsesOk("CREATE TABLE Foo PRIMARY KEY (a, b) 
PARTITION BY HASH (b) PARTITIONS 2 " +
line too long (95 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3215
PS6, Line 3215:     helper.ParserError("CREATE TABLE Foo ROW FORMAT DELIMITED 
STORED AS PARQUET AS SELECT");
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3229
PS6, Line 3229:     helper.ParsesOk("CREATE TABLE Foo PARTITIONED BY (a) ROW 
FORMAT DELIMITED STORED AS " +
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3238
PS6, Line 3238:     helper.ParsesOk("CREATE TABLE Foo PRIMARY KEY (i) PARTITION 
BY HASH(i) PARTITIONS 4 AS " +
line too long (94 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3241
PS6, Line 3241:     helper.ParsesOk("CREATE TABLE Foo PRIMARY KEY (a) PARTITION 
BY HASH(a) PARTITIONS 4 " +
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3427
PS6, Line 3427:       helper.ParsesOk(String.format("CREATE TABLE t (i MAP<%s, 
%s>)", typeDefStr, typeDefStr));
line too long (95 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3605
PS6, Line 3605:     helper.ParserError("select c, b, c,c,c,c,c,c,c,c,c,a a 
a,c,c,c,c,c,c,c,cd,c,d,d,,c, from t",
line too long (96 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3615
PS6, Line 3615:     helper.ParserError("select a a a, b, 
c,c,c,c,c,c,c,c,c,c,c,c,c,c,c,c,cd,c,d,d,,c, from t",
line too long (94 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3625
PS6, Line 3625:     helper.ParserError("select a, b, 
c,c,c,c,c,c,c,c,c,c,c,c,c,c,c,c,cd,c,d,d, ,c, from t",
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@3718
PS6, Line 3718:     helper.ParsesOk("SELECT * FROM foo WHERE EXISTS (SELECT a 
FROM bar WHERE b < 0) AND " +
line too long (91 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@4120
PS6, Line 4120:     helper.ParsesOk("COMPUTE STATS functional.alltypes 
TABLESAMPLE SYSTEM(10) REPEATABLE(10)");
line too long (95 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@4133
PS6, Line 4133:     helper.ParsesOk("COMPUTE INCREMENTAL STATS 
functional.alltypes(tinyint_col, smallint_col)");
line too long (96 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@4141
PS6, Line 4141:     helper.ParserError("COMPUTE INCREMENTAL STATS 
functional.alltypes TABLESAMPLE SYSTEM(10)");
line too long (95 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@4215
PS6, Line 4215:       helper.ParserError(String.format("ALTER DATABASE %s SET 
OWNER ROLE %s", invalid, invalid));
line too long (97 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@4216
PS6, Line 4216:       helper.ParserError(String.format("ALTER DATABASE %s SET 
OWNER USER %s", invalid, invalid));
line too long (97 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@4234
PS6, Line 4234:         helper.ParsesOk(String.format("ALTER %s %s SET OWNER 
USER %s", type, valid, valid));
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@4235
PS6, Line 4235:         helper.ParsesOk(String.format("ALTER %s %s SET OWNER 
ROLE %s", type, valid, valid));
line too long (92 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@4239
PS6, Line 4239:         helper.ParserError(String.format("ALTER %s %s SET OWNER 
ROLE %s", type, invalid, invalid));
line too long (99 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@4240
PS6, Line 4240:         helper.ParserError(String.format("ALTER %s %s SET OWNER 
USER %s", type, invalid, invalid));
line too long (99 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/fe/src/test/java/org/apache/impala/analysis/ParserTest.java@4243
PS6, Line 4243:       helper.ParserError(String.format("ALTER %s tbl 
PARTITION(i=1) SET OWNER ROLE foo", type));
line too long (96 > 90)


http://gerrit.cloudera.org:8080/#/c/21600/6/java/calcite-planner/src/test/java/org/apache/impala/CalciteParserTestHelperImpl.java
File 
java/calcite-planner/src/test/java/org/apache/impala/CalciteParserTestHelperImpl.java:

http://gerrit.cloudera.org:8080/#/c/21600/6/java/calcite-planner/src/test/java/org/apache/impala/CalciteParserTestHelperImpl.java@246
PS6, Line 246:         throw new RuntimeException("Statment did not parse in 
Calcite but parsed in Impala: " + stmt);
line too long (102 > 90)



-- 
To view, visit http://gerrit.cloudera.org:8080/21600
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I32da9f84dd70a933f24f5257fb02853f6316e6c2
Gerrit-Change-Number: 21600
Gerrit-PatchSet: 6
Gerrit-Owner: Steve Carlin <[email protected]>
Gerrit-Reviewer: Aman Sinha <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Joe McDonnell <[email protected]>
Gerrit-Comment-Date: Mon, 14 Oct 2024 13:20:58 +0000
Gerrit-HasComments: Yes

Reply via email to