Andrew Sherman has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21896 )

Change subject: IMPALA-12146: Fix incorrect host memory reserved when the 
executor quits abnormally
......................................................................


Patch Set 4: Code-Review+2

(2 comments)

Thanks for the fix

http://gerrit.cloudera.org:8080/#/c/21896/4//COMMIT_MSG
Commit Message:

http://gerrit.cloudera.org:8080/#/c/21896/4//COMMIT_MSG@18
PS4, Line 18: for
Nit: delete "for"


http://gerrit.cloudera.org:8080/#/c/21896/4/be/src/scheduling/admission-controller-test.cc
File be/src/scheduling/admission-controller-test.cc:

http://gerrit.cloudera.org:8080/#/c/21896/4/be/src/scheduling/admission-controller-test.cc@550
PS4, Line 550: being
Nit "is"



--
To view, visit http://gerrit.cloudera.org:8080/21896
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic6f6edd28c55904d63d0c494230ee2bf7a0f6cce
Gerrit-Change-Number: 21896
Gerrit-PatchSet: 4
Gerrit-Owner: Yida Wu <[email protected]>
Gerrit-Reviewer: Abhishek Rawat <[email protected]>
Gerrit-Reviewer: Andrew Sherman <[email protected]>
Gerrit-Reviewer: Impala Public Jenkins <[email protected]>
Gerrit-Reviewer: Yida Wu <[email protected]>
Gerrit-Comment-Date: Mon, 14 Oct 2024 23:29:32 +0000
Gerrit-HasComments: Yes

Reply via email to