Sai Hemanth Gantasala has posted comments on this change. ( http://gerrit.cloudera.org:8080/21662 )
Change subject: IMPALA-12758: Fix catalogd not setting prev_id for reloaded partitions ...................................................................... Patch Set 6: (6 comments) http://gerrit.cloudera.org:8080/#/c/21662/5//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/21662/5//COMMIT_MSG@7 PS5, Line 7: IMPALA-12758: Fix catalogd not setting prev_id for reloaded partitions > Please update the commit message. This is not only used by the event-proces Ack http://gerrit.cloudera.org:8080/#/c/21662/5//COMMIT_MSG@12 PS5, Line 12: ads : will > nit: "statestore" Ack http://gerrit.cloudera.org:8080/#/c/21662/5//COMMIT_MSG@13 PS5, Line 13: ion. : : This patch addresses this issu > It's unclear to me what do we mean by "request the new partition informatio Ack http://gerrit.cloudera.org:8080/#/c/21662/5/tests/custom_cluster/test_local_catalog.py File tests/custom_cluster/test_local_catalog.py: http://gerrit.cloudera.org:8080/#/c/21662/5/tests/custom_cluster/test_local_catalog.py@580 PS5, Line 580: hms_event_polling_interval_s=0 > If the default interval doesn't work, let's set this to 0 to avoid flakines Ack http://gerrit.cloudera.org:8080/#/c/21662/5/tests/custom_cluster/test_local_catalog.py@587 PS5, Line 587: # Make the partition loaded in the coordinator, so that one instance needs to be > Please add a comment to explain the purpose of this, e.g. "Make the partiti Ack http://gerrit.cloudera.org:8080/#/c/21662/5/tests/custom_cluster/test_local_catalog.py@589 PS5, Line 589: self.client.execute("show partitions {}".format(test_tbl)) > nit: change "p=\d" to "p=0" and change "%%d" to "0" Ack -- To view, visit http://gerrit.cloudera.org:8080/21662 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ia7d53f601b63d83e99cbd2d1f58076a0dc78c610 Gerrit-Change-Number: 21662 Gerrit-PatchSet: 6 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Tue, 15 Oct 2024 20:13:39 +0000 Gerrit-HasComments: Yes
