Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/21921 )
Change subject: IMPALA-13446: Bump CDP GBN to 58457853 to get Ranger improvements ...................................................................... Patch Set 3: Code-Review+2 (1 comment) Thanks for taking care of this Joe! I don't have any additional suggestion. We could merge the patch once there is no failed test. http://gerrit.cloudera.org:8080/#/c/21921/3/tests/metadata/test_metadata_query_statements.py File tests/metadata/test_metadata_query_statements.py: http://gerrit.cloudera.org:8080/#/c/21921/3/tests/metadata/test_metadata_query_statements.py@170 PS3, Line 170: # Some versions of HMS will fail to create the database if the managed directory : # is already present. This is not a test for HMS, so this uses unique directory : # names to workaround the issue. Thanks for the code comment! I tried running the following 2 statements through impala-shell and beeline respectively, and verified the HMS or HS2 associated with the CDP GBN in this patch indeed has some bugs. // In impala-shell connected to the Impala server create database impala_test_desc_db4 comment 'test comment' location "/test-warehouse/test2.db"; // In beeline connected to HiveServer2 create database hive_test_desc_db2 comment 'test comment' managedlocation "/test-warehouse/test2.db"; // Encountered the following error returned from HiveServer2 ERROR : FAILED: Execution Error, return code 40000 from org.apache.hadoop.hive.ql.ddl.DDLTask. MetaException(message:Unable to create database managed directory hdfs://localhost:20500/test-warehouse/test2.db, failed to create database hive_test_desc_db2) -- To view, visit http://gerrit.cloudera.org:8080/21921 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I32727020a69a66c3af4f4096fe15bc81600e2215 Gerrit-Change-Number: 21921 Gerrit-PatchSet: 3 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Tue, 15 Oct 2024 23:05:13 +0000 Gerrit-HasComments: Yes
