Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/21926 )
Change subject: IMPALA-13431: Deflake TestLogging.test_excessive_cerr_ignore_pid ...................................................................... IMPALA-13431: Deflake TestLogging.test_excessive_cerr_ignore_pid On a couple UBSAN runs, test_excessive_cerr_ignore_pid sometimes fails find the message providing the next path in the last line of the ERROR log file. The logs aren't preserved, so we don't know the exact contents of the log file. This does two things: 1. It changes the test to preserve the log file on failure by copying from the temporary directory to a directory that will last past the end of the test. This gives us data to work with if we see this again. 2. A theory is that an extra line or two of logging could go to the file after it writes the message with the next path. This changes the test to check the last 3 lines of the log file for the message providing the next path. Testing: - Ran test with UBSAN Change-Id: I4745184e983ee5669822059289aab18caf0b72a9 Reviewed-on: http://gerrit.cloudera.org:8080/21926 Reviewed-by: Michael Smith <[email protected]> Tested-by: Impala Public Jenkins <[email protected]> --- M tests/custom_cluster/test_breakpad.py 1 file changed, 24 insertions(+), 6 deletions(-) Approvals: Michael Smith: Looks good to me, approved Impala Public Jenkins: Verified -- To view, visit http://gerrit.cloudera.org:8080/21926 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: merged Gerrit-Change-Id: I4745184e983ee5669822059289aab18caf0b72a9 Gerrit-Change-Number: 21926 Gerrit-PatchSet: 2 Gerrit-Owner: Joe McDonnell <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]>
