Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/21930 )
Change subject: IMPALA-12648: Add KILL QUERY statement ...................................................................... Patch Set 2: (1 comment) Thanks for the efforts Xuebin! I left a comment on KillQueryStmt.java regarding my understanding of the usage of setMaskPrivChecks(). I will keep reading the rest of the patch and provide suggestions if there is any. http://gerrit.cloudera.org:8080/#/c/21930/2/fe/src/main/java/org/apache/impala/analysis/KillQueryStmt.java File fe/src/main/java/org/apache/impala/analysis/KillQueryStmt.java: http://gerrit.cloudera.org:8080/#/c/21930/2/fe/src/main/java/org/apache/impala/analysis/KillQueryStmt.java@60 PS2, Line 60: setMaskPrivChecks(null) I am not very sure if we have to call setMaskPrivChecks() here. According to my current understanding, the purpose of setMaskPrivChecks() is mainly to prevent the information about the underlying tables of a view from being revealed in the output of the following statements, if the requesting user does not have the necessary privileges on the underlying tables even though the requesting user is authorized to select the contents of the view. - "EXPLAIN SELECT * FROM <view>", "SHOW CREATE TABLE <view>", - "profile" command following the execution of statements like "SELECT * FROM <view>". Since the KILL QUERY statement implemented in this patch does not involve a view, maybe we don't have to call setMaskPrivChecks(). On a related note, I just found that the the information about the underlying tables of a view could still be revealed by the statement "DESCRIBE FORMATTED <view>" since the field of 'View Original Text' is not redacted when the requesting user does not have the necessary privileges on the underlying tables. But this problem is out of the scope of this patch. -- To view, visit http://gerrit.cloudera.org:8080/21930 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: If12d6e47b256b034ec444f17c7890aa3b40481c0 Gerrit-Change-Number: 21930 Gerrit-PatchSet: 2 Gerrit-Owner: Xuebin Su <[email protected]> Gerrit-Reviewer: Fang-Yu Rao <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Jason Fehr <[email protected]> Gerrit-Comment-Date: Thu, 17 Oct 2024 01:07:42 +0000 Gerrit-HasComments: Yes
