Steve Carlin has posted comments on this change. ( http://gerrit.cloudera.org:8080/21945 )
Change subject: IMPALA-13459: Handle duplicate table in same query ...................................................................... Patch Set 2: (2 comments) http://gerrit.cloudera.org:8080/#/c/21945/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/util/SimplifiedAnalyzer.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/util/SimplifiedAnalyzer.java: http://gerrit.cloudera.org:8080/#/c/21945/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/util/SimplifiedAnalyzer.java@52 PS2, Line 52: private Set<String> uniqueTableAlias_; > nit: why not initialize here like you did for unassignedConjuncts_? Fixed, more consistent now http://gerrit.cloudera.org:8080/#/c/21945/2/java/calcite-planner/src/main/java/org/apache/impala/calcite/util/SimplifiedAnalyzer.java@137 PS2, Line 137: * Given an alias name, check if it is unique based on previously > Maybe mention IMPALA-13460 around here? Done -- To view, visit http://gerrit.cloudera.org:8080/21945 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ib9997bc642c320c2e26294d7d02a05bccbba6a0d Gerrit-Change-Number: 21945 Gerrit-PatchSet: 2 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Steve Carlin <[email protected]> Gerrit-Comment-Date: Thu, 17 Oct 2024 19:30:46 +0000 Gerrit-HasComments: Yes
