Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/21927 )
Change subject: IMPALA-13445: Ignore num partition for unpartitioned writes ...................................................................... Patch Set 7: Code-Review+2 (1 comment) Thanks for fixing this, LGTM! http://gerrit.cloudera.org:8080/#/c/21927/6/fe/src/main/java/org/apache/impala/planner/HdfsTableSink.java File fe/src/main/java/org/apache/impala/planner/HdfsTableSink.java: http://gerrit.cloudera.org:8080/#/c/21927/6/fe/src/main/java/org/apache/impala/planner/HdfsTableSink.java@457 PS6, Line 457: maxWriters = totalNumPartitions > I'm not sure. totalNumPartitions most likely has been over estimated becaus I see, however in a lot of cases there's only a single partition column. Since maxNumWriters limit the number of writers anyway, and with hash-based shuffling we wouldn't write too many files, we could probably allow more writers. But this can be a follow-up discussion. -- To view, visit http://gerrit.cloudera.org:8080/21927 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I51ab8fc35a5489351a88d372b28642b35449acfc Gerrit-Change-Number: 21927 Gerrit-PatchSet: 7 Gerrit-Owner: Riza Suminto <[email protected]> Gerrit-Reviewer: Abhishek Rawat <[email protected]> Gerrit-Reviewer: David Rorke <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: Wenzhe Zhou <[email protected]> Gerrit-Reviewer: Zoltan Borok-Nagy <[email protected]> Gerrit-Comment-Date: Fri, 18 Oct 2024 20:10:21 +0000 Gerrit-HasComments: Yes
