Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21946 )
Change subject: IMPALA-13457: Calcite planner: fix datetime/interval issues for tpcds queries ...................................................................... Patch Set 3: Code-Review+2 (1 comment) http://gerrit.cloudera.org:8080/#/c/21946/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java File java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java: http://gerrit.cloudera.org:8080/#/c/21946/3/java/calcite-planner/src/main/java/org/apache/impala/calcite/coercenodes/CoerceOperandShuttle.java@33 PS3, Line 33: import org.apache.calcite.sql.fun.SqlDatetimePlusOperator; I'm offended these aren't Addition/Subtraction or Plus/Minus. Not that we have any control over them. -- To view, visit http://gerrit.cloudera.org:8080/21946 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I2b4afc3ab1d17ba1f168904a6ded052e1d62b3fe Gerrit-Change-Number: 21946 Gerrit-PatchSet: 3 Gerrit-Owner: Steve Carlin <[email protected]> Gerrit-Reviewer: Aman Sinha <[email protected]> Gerrit-Reviewer: Anonymous Coward (816) Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Comment-Date: Fri, 18 Oct 2024 22:01:39 +0000 Gerrit-HasComments: Yes
