Yida Wu has posted comments on this change. ( 
http://gerrit.cloudera.org:8080/21955 )

Change subject: IMPALA-13465: Trace TupleId further to reduce Agg cardinality
......................................................................


Patch Set 2:

(2 comments)

http://gerrit.cloudera.org:8080/#/c/21955/2/fe/src/main/java/org/apache/impala/planner/AggregationNode.java
File fe/src/main/java/org/apache/impala/planner/AggregationNode.java:

http://gerrit.cloudera.org:8080/#/c/21955/2/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@327
PS2, Line 327: slotRef.getDesc()
nit. can use short term "sd"


http://gerrit.cloudera.org:8080/#/c/21955/2/fe/src/main/java/org/apache/impala/planner/AggregationNode.java@331
PS2, Line 331: slotRef.getDesc()
nit. can use short term "sd"



-- 
To view, visit http://gerrit.cloudera.org:8080/21955
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I11f59ccc469c24c1800abaad3774c56190306944
Gerrit-Change-Number: 21955
Gerrit-PatchSet: 2
Gerrit-Owner: Riza Suminto <riza.sumi...@cloudera.com>
Gerrit-Reviewer: Aman Sinha <amsi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <impala-public-jenk...@cloudera.com>
Gerrit-Reviewer: Michael Smith <michael.sm...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <riza.sumi...@cloudera.com>
Gerrit-Reviewer: Yida Wu <wydbaggio...@gmail.com>
Gerrit-Comment-Date: Mon, 21 Oct 2024 05:56:40 +0000
Gerrit-HasComments: Yes

Reply via email to