Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21905 )
Change subject: IMPALA-11761: Run large dir tests serially ...................................................................... Patch Set 1: (1 comment) http://gerrit.cloudera.org:8080/#/c/21905/1/tests/metadata/test_recursive_listing.py File tests/metadata/test_recursive_listing.py: http://gerrit.cloudera.org:8080/#/c/21905/1/tests/metadata/test_recursive_listing.py@171 PS1, Line 171: @pytest.mark.execute_serially > Am I right that this change want to put back @pytest.mark.execute_serially It is. I may have partially misunderstood "stress" the first time. These marks are only used for * https://github.com/apache/impala/blob/master/tests/run-tests.py#L310 to run tests serially (as it doesn't supply a '-n' argument) * https://github.com/apache/impala/blob/master/tests/run-tests.py#L316 to run stress tests concurrently ('-n NUM_STRESS_CLIENTS', which defaults to 4x #CPUs) * https://github.com/apache/impala/blob/master/tests/run-tests.py#L322 to run all other tests in parallel When they previously used both execute_serially and stress, that meant the tests would be run serially first (since they matched the 1st mark), then as part of a stress test running many clients at once (2nd mark). The concept of stress tests appears to have been added in https://github.com/apache/impala/commit/409d2ae5d7a301f1a1040cad667da517ebde9b79#diff-4df71b389eaed17aa1d651bc8d40d4f67356af9eb04af052c7c5483c0c9f56d1. I think it has been misunderstood several times since. I can try to clarify the pytest.ini description a bit. -- To view, visit http://gerrit.cloudera.org:8080/21905 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I1f7d2017ae1bab0f2f8cb0b100c2c6cc8b4f3dcd Gerrit-Change-Number: 21905 Gerrit-PatchSet: 1 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 21 Oct 2024 17:28:54 +0000 Gerrit-HasComments: Yes
