Pranav Lodha has posted comments on this change. ( http://gerrit.cloudera.org:8080/20447 )
Change subject: IMPALA-13039: AES Encryption/ Decryption Support in Impala ...................................................................... Patch Set 22: (5 comments) > Uploaded patch set 22. http://gerrit.cloudera.org:8080/#/c/20447/21/be/src/exprs/string-functions-ir.cc File be/src/exprs/string-functions-ir.cc: http://gerrit.cloudera.org:8080/#/c/20447/21/be/src/exprs/string-functions-ir.cc@1875 PS21, Line 1875: " > Nit: add space after the comma. Done http://gerrit.cloudera.org:8080/#/c/20447/21/be/src/exprs/string-functions-ir.cc@1875 PS21, Line 1875: : > Seeing the test with the empty string, it's better to surround the mode wit Done http://gerrit.cloudera.org:8080/#/c/20447/21/be/src/exprs/string-functions-ir.cc@1884 PS21, Line 1884: EncryptionKey: > ModeToString() is static, should call it like EncryptionKey::ModeToString() Done http://gerrit.cloudera.org:8080/#/c/20447/21/be/src/exprs/string-functions-ir.cc@1906 PS21, Line 1906: > In case of decryption, the clear text size should never be greater than the Done http://gerrit.cloudera.org:8080/#/c/20447/21/be/src/exprs/string-functions-ir.cc@1915 PS21, Line 1915: DCHECK(len_diff == 0 || (encryption_key.IsEcbMode() && 0 < len_diff && > Before this assignment, we could add this to assert the correctness of the Done -- To view, visit http://gerrit.cloudera.org:8080/20447 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I3902f2b1d95da4d06995cbd687e79c48e16190c9 Gerrit-Change-Number: 20447 Gerrit-PatchSet: 22 Gerrit-Owner: Pranav Lodha <[email protected]> Gerrit-Reviewer: Alexey Serbin <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Noemi Pap-Takacs <[email protected]> Gerrit-Reviewer: Pranav Lodha <[email protected]> Gerrit-Comment-Date: Wed, 23 Oct 2024 10:11:59 +0000 Gerrit-HasComments: Yes
