Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/21970 )
Change subject: IMPALA-13473: Add support for JS code analysis and linting with ESLint ...................................................................... Patch Set 1: (2 comments) http://gerrit.cloudera.org:8080/#/c/21970/1/www/scripts/eslint.config.js File www/scripts/eslint.config.js: http://gerrit.cloudera.org:8080/#/c/21970/1/www/scripts/eslint.config.js@1 PS1, Line 1: import globals from "globals"; This should have a license if we can add it. http://gerrit.cloudera.org:8080/#/c/21970/1/www/scripts/eslint/eslint_custom_output_formatter.js File www/scripts/eslint/eslint_custom_output_formatter.js: http://gerrit.cloudera.org:8080/#/c/21970/1/www/scripts/eslint/eslint_custom_output_formatter.js@1 PS1, Line 1: export default function (results) { RAT expects a license comment. -- To view, visit http://gerrit.cloudera.org:8080/21970 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: Ieb3d0a9221738e2ac6fefd60087eaeee4366e33f Gerrit-Change-Number: 21970 Gerrit-PatchSet: 1 Gerrit-Owner: Surya Hebbar <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Surya Hebbar <[email protected]> Gerrit-Comment-Date: Wed, 23 Oct 2024 22:52:01 +0000 Gerrit-HasComments: Yes
