Michael Smith has posted comments on this change. ( http://gerrit.cloudera.org:8080/20494 )
Change subject: IMPALA-12390 (part 4): Enable unnecessary-value-param ...................................................................... Patch Set 10: (2 comments) http://gerrit.cloudera.org:8080/#/c/20494/10//COMMIT_MSG Commit Message: http://gerrit.cloudera.org:8080/#/c/20494/10//COMMIT_MSG@14 PS10, Line 14: move into place > question: I thought std::move is implied by compiler in some obvious case. clang-tidy would complain. Most cases of automatic "move" are https://en.cppreference.com/w/cpp/language/copy_elision. As far as I know, there are no automatic moves in a constructor; the compiler could probably figure them out, but it has to ensure there are no other references within the constructor (including any function calls) and I don't think any do that analysis. http://gerrit.cloudera.org:8080/#/c/20494/10//COMMIT_MSG@19 PS10, Line 19: cascading changes to other calls. > Curious, which call path has the deepest cascading change? I'll have to rediscover that. I'm going to work on splitting this up into a couple patches to make the types of changes clearer. -- To view, visit http://gerrit.cloudera.org:8080/20494 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I8aa5d98596d82f615a0a728e0235e7dd9d8b5003 Gerrit-Change-Number: 20494 Gerrit-PatchSet: 10 Gerrit-Owner: Michael Smith <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Joe McDonnell <[email protected]> Gerrit-Reviewer: Michael Smith <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Reviewer: gaurav singh <[email protected]> Gerrit-Comment-Date: Fri, 25 Oct 2024 23:39:31 +0000 Gerrit-HasComments: Yes
