Peter Rozsa has posted comments on this change. ( http://gerrit.cloudera.org:8080/21964 )
Change subject: IMPALA-13467: Fix partition list size calculation for empty Iceberg scan nodes ...................................................................... Patch Set 4: (1 comment) http://gerrit.cloudera.org:8080/#/c/21964/4/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java File fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java: http://gerrit.cloudera.org:8080/#/c/21964/4/fe/src/main/java/org/apache/impala/planner/HdfsScanNode.java@1226 PS4, Line 1226: allParquet = partitionsSize > 0; > In this case, when can 'partitionsSize' be zero? If the scan node is not an IcebergScanNode and has zero partitions -- To view, visit http://gerrit.cloudera.org:8080/21964 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I5a0595831f3bd87074144ab7d5da27508e73ef33 Gerrit-Change-Number: 21964 Gerrit-PatchSet: 4 Gerrit-Owner: Peter Rozsa <[email protected]> Gerrit-Reviewer: Daniel Becker <[email protected]> Gerrit-Reviewer: Gabor Kaszab <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Peter Rozsa <[email protected]> Gerrit-Reviewer: Riza Suminto <[email protected]> Gerrit-Comment-Date: Mon, 28 Oct 2024 09:50:51 +0000 Gerrit-HasComments: Yes
