Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/21665 )
Change subject: IMPALA-12865: enable_reload_events breaks enable_skipping_older_events by pushing lastRefreshEventId too high ...................................................................... Patch Set 3: (2 comments) http://gerrit.cloudera.org:8080/#/c/21665/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java File fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java: http://gerrit.cloudera.org:8080/#/c/21665/3/fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java@7176 PS3, Line 7176: currentHMSEventId Is it possible for this to be -1? http://gerrit.cloudera.org:8080/#/c/21665/3/tests/custom_cluster/test_events_custom_configs.py File tests/custom_cluster/test_events_custom_configs.py: http://gerrit.cloudera.org:8080/#/c/21665/3/tests/custom_cluster/test_events_custom_configs.py@1210 PS3, Line 1210: self.client.execute_async("refresh {} partition(year=2024)".format(tbl)) : self.run_stmt_in_hive( : "alter table {} partition(year=2024) set location '/tmp'".format(tbl)) Did this actually reproduce the bug before the fix? As alter table is after the refresh, why would the event processor skip it? My understanding is that refresh and parallel has to happen in parallel to get problematic behavior. -- To view, visit http://gerrit.cloudera.org:8080/21665 To unsubscribe, visit http://gerrit.cloudera.org:8080/settings Gerrit-Project: Impala-ASF Gerrit-Branch: master Gerrit-MessageType: comment Gerrit-Change-Id: I90039da77ec561c5aede44456f88c6650582815b Gerrit-Change-Number: 21665 Gerrit-PatchSet: 3 Gerrit-Owner: Sai Hemanth Gantasala <[email protected]> Gerrit-Reviewer: Csaba Ringhofer <[email protected]> Gerrit-Reviewer: Impala Public Jenkins <[email protected]> Gerrit-Reviewer: Quanlong Huang <[email protected]> Gerrit-Reviewer: Sai Hemanth Gantasala <[email protected]> Gerrit-Comment-Date: Tue, 29 Oct 2024 06:13:23 +0000 Gerrit-HasComments: Yes
